From 1c01613bce5f5119bd21b9bf90d12b9ca4b27690 Mon Sep 17 00:00:00 2001 From: "shuwen.wu" Date: Fri, 25 Sep 2026 20:22:43 +0800 Subject: [PATCH] fix: add missing response types for issues #2459 and #2550 - Add FilesUploadV2Response type for files.uploadV2 method (issue #2459) - Add missing 'latest' field and Latest interface to ConversationsSetTopicResponse (issue #2550) - All manual additions marked with 'Manual addition pending regeneration' comment --- packages/web-api/src/WebClient.ts | 3 ++- packages/web-api/src/methods.ts | 3 ++- .../src/types/response/ConversationsSetTopicResponse.ts | 9 +++++++++ .../web-api/src/types/response/FilesUploadV2Response.ts | 7 +++++++ packages/web-api/src/types/response/index.ts | 1 + 5 files changed, 21 insertions(+), 2 deletions(-) create mode 100644 packages/web-api/src/types/response/FilesUploadV2Response.ts diff --git a/packages/web-api/src/WebClient.ts b/packages/web-api/src/WebClient.ts index e212cf5dd..26be98d94 100644 --- a/packages/web-api/src/WebClient.ts +++ b/packages/web-api/src/WebClient.ts @@ -27,6 +27,7 @@ import type { AdminAnalyticsPublicChannelMetadataDetails, FilesCompleteUploadExternalResponse, FilesGetUploadURLExternalResponse, + FilesUploadV2Response, // Manual addition pending regeneration } from './types/response'; /* @@ -468,7 +469,7 @@ export class WebClient extends Methods { */ public async filesUploadV2( options: FilesUploadV2Arguments, - ): Promise { + ): Promise { this.logger.debug('files.uploadV2() start'); // 1 const fileUploads = await this.getAllFileUploads(options); diff --git a/packages/web-api/src/methods.ts b/packages/web-api/src/methods.ts index f307dff90..d8db6c8df 100644 --- a/packages/web-api/src/methods.ts +++ b/packages/web-api/src/methods.ts @@ -470,6 +470,7 @@ import type { FilesRemoteUpdateResponse, FilesRevokePublicURLResponse, FilesSharedPublicURLResponse, + FilesUploadV2Response, // Manual addition pending regeneration FunctionsCompleteErrorResponse, FunctionsCompleteSuccessResponse, MigrationExchangeResponse, @@ -2026,7 +2027,7 @@ export abstract class Methods extends EventEmitter { * as multiple file uploads property. * @see {@link https://docs.slack.dev/tools/node-slack-sdk/web-api/#upload-a-file `@slack/web-api` Upload a file documentation}. */ - uploadV2: bindFilesUploadV2(this), + uploadV2: bindFilesUploadV2(this), comments: { /** * @description Deletes an existing comment on a file. diff --git a/packages/web-api/src/types/response/ConversationsSetTopicResponse.ts b/packages/web-api/src/types/response/ConversationsSetTopicResponse.ts index 845b5115d..d5d52cb1c 100644 --- a/packages/web-api/src/types/response/ConversationsSetTopicResponse.ts +++ b/packages/web-api/src/types/response/ConversationsSetTopicResponse.ts @@ -35,6 +35,7 @@ export interface Channel { is_private?: boolean; is_shared?: boolean; last_read?: string; + latest?: Latest; // Manual addition pending regeneration name?: string; name_normalized?: string; pending_connected_team_ids?: string[]; @@ -47,6 +48,14 @@ export interface Channel { updated?: number; } +export interface Latest { // Manual addition pending regeneration + subtype?: string; + text?: string; + ts?: string; + type?: string; + user?: string; +} + export interface Purpose { creator?: string; last_set?: number; diff --git a/packages/web-api/src/types/response/FilesUploadV2Response.ts b/packages/web-api/src/types/response/FilesUploadV2Response.ts new file mode 100644 index 000000000..8f6cc34fb --- /dev/null +++ b/packages/web-api/src/types/response/FilesUploadV2Response.ts @@ -0,0 +1,7 @@ +import type { WebAPICallResult } from '../../WebClient'; +import type { FilesCompleteUploadExternalResponse } from './FilesCompleteUploadExternalResponse'; + +// Manual addition pending regeneration +export interface FilesUploadV2Response extends WebAPICallResult { + files: FilesCompleteUploadExternalResponse[]; +} diff --git a/packages/web-api/src/types/response/index.ts b/packages/web-api/src/types/response/index.ts index 2e1937f7e..f51ab3bca 100644 --- a/packages/web-api/src/types/response/index.ts +++ b/packages/web-api/src/types/response/index.ts @@ -225,6 +225,7 @@ export { FilesRemoteUpdateResponse } from './FilesRemoteUpdateResponse'; export { FilesRevokePublicURLResponse } from './FilesRevokePublicURLResponse'; export { FilesSharedPublicURLResponse } from './FilesSharedPublicURLResponse'; export { FilesUploadResponse } from './FilesUploadResponse'; +export { FilesUploadV2Response } from './FilesUploadV2Response'; // Manual addition pending regeneration export { FunctionsCompleteErrorResponse } from './FunctionsCompleteErrorResponse'; export { FunctionsCompleteSuccessResponse } from './FunctionsCompleteSuccessResponse'; export { GroupsArchiveResponse } from './GroupsArchiveResponse';