This repository was archived by the owner on May 14, 2026. It is now read-only.
External traffic policy and static auth secrets#177
Closed
ericomeehan wants to merge 4 commits into
Closed
Conversation
Author
|
The |
Author
|
These configuration fields are documented here. |
Collaborator
|
Neat! Can you please bump the chart version in Chart.yaml? Then I can see about getting this merged. Thank you 🙏 |
jessebot
reviewed
Feb 1, 2026
| export CONNECTION_STRING="host=$DATABASE_HOSTNAME dbname=$DATABASE user=$DATABASE_USER password=$DATABASE_PASS port=3306 connect_timeout=10 read_timeout=10" && \ | ||
| yq eval -i '.mysql-userdb = env(CONNECTION_STRING)' /data/turnserver.yaml && \ | ||
| {{- end }} | ||
| sed -i '1i use-auth-secret' /data/turnserver.yaml && \ |
Collaborator
There was a problem hiding this comment.
ok, tested it locally, and it just adds a plain value. awesome, yeah, let me see what I can do in a new PR.
jessebot
added a commit
that referenced
this pull request
Feb 1, 2026
Thanks to @ericomeehan for initial work in #177 co-authored by: @ericomeehan
jessebot
added a commit
that referenced
this pull request
Feb 1, 2026
…Vars` parameter (#194) * Add ExternalTrafficPolicy defaults and coturn.extraEnvVars parameter Thanks to @ericomeehan for initial work in #177 co-authored by: @ericomeehan * helm-docs: automated action --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Collaborator
|
I went ahead and got some of these changes in, but I would still need the chart version bumped on this, and that line I pointed out explained. Regardless, credited you on the stuff I did merge. I would do the updates on your PR branch, but you are using the |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds information and a default value for
externalTrafficPolicyand configures static auth using the shared secret from the matrix-chart. The changes proposed here have been tested and verified to work for voice and video calls.