Very slow staging files on big repositories on macOS

[kunitoki]

I'm experiencing very slow (sometimes it takes even 20 seconds) staging of changed files on big repositories on macOS. Other git clients or even git from command line don't exhibit the same behaviour, is it something you are experiencing ?

[love-linger]

Can not re-produce on my macOS device. I just tested it in my Unreal Engine repo.

[kunitoki]

My repo is really big, once i have generated and compiled the final product, it's around 40GB in size and can contain over 200k files

[AlanIWBFT]

git status equals to git status --untracked-files=normal. Afaik, --untracked-files=all can be very slow on Windows (~5 to ~20s on UE5 repo, seems depending on how much you touched). On Linux it is much faster (~1s consistenly). It just seems like Git's untracked cache is not helping so much when -uall is added. Since -uall is required to accurately report what has been changed (so that you see each untracked file), I see this as a Git issue thus there's no easy solution. On Windows I just comment out all code that uses -uall in SourceGit and only manually look for untracked files when I need.

[love-linger]

On Windows I just comment out all code that uses -uall in SourceGit and only manually look for untracked files when I need.

Actually, after I tested it, I don't feel any changes.

[love-linger]

I've pushed a commit that tries to improve stage/unstage/discard performance. You can test it.

[AlanIWBFT]

Actually, after I tested it, I don't feel any changes.

The effect is the most pronounced when Visual Studio is running:

PS E:\ue5-main> Measure-Command { git status --untracked-files=all }

Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 11
Milliseconds      : 41
Ticks             : 110412224
TotalDays         : 0.000127791925925926
TotalHours        : 0.00306700622222222
TotalMinutes      : 0.184020373333333
TotalSeconds      : 11.0412224
TotalMilliseconds : 11041.2224

PS E:\ue5-main> Measure-Command { git status }

Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 0
Milliseconds      : 469
Ticks             : 4699134
TotalDays         : 5.4388125E-06
TotalHours        : 0.0001305315
TotalMinutes      : 0.00783189
TotalSeconds      : 0.4699134
TotalMilliseconds : 469.9134

I have tested your new commit and it doesn't resolve the issue. It's not the stage/unstage operation that's slow, but the status query after that:

SourceGit_0OmLcY589j.mp4

If I click the eye icon to disable IncludeUntracked, it completes immedately.
edit: Make sure you have disabled GitDependencies hooks if you're testing on UE5 to rule out these unrelated factors

[love-linger]

I know that git status costs too much time. But I do not think it is a good idea to use -unormal instead of -uall. For example: there's a new folder that contains many of new files, it is impossible to add just some of them in this way (because there's only one folder changed record)

[love-linger]

And git add . costs more time than git add --pathspec-from-file=<pathspec>

[love-linger]

https://git-scm.com/docs/git-fsmonitor--daemon

[AlanIWBFT]

But I do not think it is a good idea to use -unormal instead of -uall

Yes I know so I said there's no easy solution to this problem. Also I have both untracked cache and fsmonitor on.