From 0284e93d9041dee756adcb3603a0fc9c6d41c608 Mon Sep 17 00:00:00 2001 From: Manuel de Brito Fontes Date: Thu, 1 Oct 2026 20:35:52 -0300 Subject: [PATCH] ci: an edit to versions/gate_test.go builds none of the artefacts The versions tool is go-tools' since a8e2737, pinned by go.mod; versions/ holds only the gate's test. It was still in the three build lanes' path filters and hack/touches lists, so editing that test built QEMU, the kernel and the base image. Co-Authored-By: Claude Opus 5.5 (1M context) --- .github/workflows/image.yml | 4 +--- .github/workflows/kernel.yml | 4 +--- .github/workflows/qemu.yml | 6 ++---- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/.github/workflows/image.yml b/.github/workflows/image.yml index 82f18a0..307d37b 100644 --- a/.github/workflows/image.yml +++ b/.github/workflows/image.yml @@ -18,7 +18,6 @@ on: - image/** - e2fsprogs/** - versions.yaml - - versions/** - go.mod - .github/workflows/image.yml pull_request: @@ -26,7 +25,6 @@ on: - image/** - e2fsprogs/** - versions.yaml - - versions/** - go.mod - .github/workflows/image.yml workflow_dispatch: @@ -64,7 +62,7 @@ jobs: BASE: ${{ github.event.pull_request.base.sha || github.event.before }} run: | build=$(hack/touches "$BASE" alpine e2fsprogs ubuntu mkosi task git-lfs buildkit -- \ - image e2fsprogs versions go.mod .github/workflows/image.yml) + image e2fsprogs go.mod .github/workflows/image.yml) echo "build=${build}" | tee -a "$GITHUB_OUTPUT" build: diff --git a/.github/workflows/kernel.yml b/.github/workflows/kernel.yml index e7066d3..79c6e5c 100644 --- a/.github/workflows/kernel.yml +++ b/.github/workflows/kernel.yml @@ -17,14 +17,12 @@ on: paths: - kernel/** - versions.yaml - - versions/** - go.mod - .github/workflows/kernel.yml pull_request: paths: - kernel/** - versions.yaml - - versions/** - go.mod - .github/workflows/kernel.yml workflow_dispatch: @@ -62,7 +60,7 @@ jobs: BASE: ${{ github.event.pull_request.base.sha || github.event.before }} run: | build=$(hack/touches "$BASE" debian debian-snapshot kernel moby-check-config -- \ - kernel versions go.mod .github/workflows/kernel.yml) + kernel go.mod .github/workflows/kernel.yml) echo "build=${build}" | tee -a "$GITHUB_OUTPUT" build: diff --git a/.github/workflows/qemu.yml b/.github/workflows/qemu.yml index 7517fa8..ab252ed 100644 --- a/.github/workflows/qemu.yml +++ b/.github/workflows/qemu.yml @@ -8,7 +8,7 @@ name: QEMU # than in a VM that will not start weeks later. on: -# qemu/**, and versions.yaml with the tool that reads it, because that is where the pins are. +# qemu/**, versions.yaml, where the pins are, and go.mod, which pins the tool that reads it. # The root Taskfile is deliberately not listed: it holds only how many jobs to compile with and # which cache to use, so listing it would rebuild QEMU, the kernel and the base image for an # edit that cannot change any of them. @@ -23,14 +23,12 @@ on: paths: - qemu/** - versions.yaml - - versions/** - go.mod - .github/workflows/qemu.yml pull_request: paths: - qemu/** - versions.yaml - - versions/** - go.mod - .github/workflows/qemu.yml workflow_dispatch: @@ -71,7 +69,7 @@ jobs: BASE: ${{ github.event.pull_request.base.sha || github.event.before }} run: | build=$(hack/touches "$BASE" alpine qemu debian debian-snapshot qboot -- \ - qemu versions go.mod .github/workflows/qemu.yml) + qemu go.mod .github/workflows/qemu.yml) echo "build=${build}" | tee -a "$GITHUB_OUTPUT" build: