fix: scope SpinAppExecutor finalizer check to executor's namespace #491
Merged
vdice merged 2 commits intoApr 14, 2026
Merged
Conversation
vdice
requested review from
bacongobbler,
calebschoepp,
endocrimes and
michelleN
as code owners
Contributor
Author
|
The handleDeletion() method lists dependent SpinApps by executor name across all namespaces. This causes a SpinApp in namespace B to block deletion of an unrelated SpinAppExecutor with the same name in namespace A — even though there are zero SpinApps in namespace A. This is particularly impactful because the common pattern (and the Helm chart bootstrap hook) uses the same executor name "containerd-shim-spin" in every namespace. All executors with that name become cross-coupled. The fix adds client.InNamespace(executor.Namespace) to scope the dependent SpinApp lookup to the executor's own namespace. Includes a regression test that creates same-named executors in two namespaces with a SpinApp only in one, then verifies deleting the executor in the other namespace succeeds. Fixes spinframework#480 Signed-off-by: John Moore <melderan@gmail.com>
…ically Signed-off-by: Vaughn Dice <vdice@akamai.com>
vdice
force-pushed
the
fix/executor-finalizer-cross-namespace
branch
from
88c1626 to
761767e
Compare
kate-goldenring
approved these changes
Apr 14, 2026
Contributor
kate-goldenring
left a comment
kate-goldenring
left a comment
There was a problem hiding this comment.
LGTM. Thanks @vdice. It may be worth doing a look over (with copilot) of other places we may be missing namespace scoping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #481 to close #480. Just rebased and applied a minor item of feedback from 481.