FME-15373-impressions: wire client/ back to impressions module

Add impressions dependency to client/pom.xml. Add adapter classes
TelemetryRuntimeImpressionsRecorder and TelemetryUniqueKeysSender to
bridge the old telemetry interfaces to the new impressions module
boundaries. Update SplitFactoryImpl to build ImpressionsManagerConfig
and use the adapters when constructing ImpressionsManagerImpl and
UniqueKeysTrackerImp. Move strategy tests and UniqueKeysTrackerImpTest
to the impressions module where their dependencies now live.

AI-Session-Id: 52375eb8-af89-45b8-bbad-1698b6636202
AI-Tool: claude-code
AI-Model: unknown

Author: gthea

client/pom.xml

@@ -172,6 +172,11 @@
             <artifactId>tracker</artifactId>
             <version>${project.version}</version>
         </dependency>
+        <dependency>
+            <groupId>io.split.client</groupId>
+            <artifactId>impressions</artifactId>
+            <version>${project.version}</version>
+        </dependency>
         <dependency>
             <groupId>io.split.client</groupId>
             <artifactId>targeting-engine</artifactId>

client/src/main/java/io/split/client/SplitFactoryImpl.java

@@ -17,8 +17,12 @@
 import io.split.client.impressions.ImpressionListener;
 import io.split.client.impressions.ImpressionObserver;
 import io.split.client.impressions.ImpressionsManager;
+import io.split.client.impressions.ImpressionsManagerConfig;
 import io.split.client.impressions.ImpressionsManagerImpl;
+import io.split.client.impressions.ImpressionsTelemetryRecorder;
 import io.split.client.impressions.ImpressionsSender;
+import io.split.client.impressions.TelemetryRuntimeImpressionsRecorder;
+import io.split.client.impressions.TelemetryUniqueKeysSender;
 import io.split.client.impressions.ImpressionsStorage;
 import io.split.client.impressions.ImpressionsStorageConsumer;
 import io.split.client.impressions.ImpressionsStorageProducer;
@@ -752,11 +756,12 @@ private ImpressionsManagerImpl buildImpressionsManager(SplitClientConfig config,
                 : null;
         ProcessImpressionNone processImpressionNone = new ProcessImpressionNone(listener != null, _uniqueKeysTracker, counter);
 
+        ImpressionsTelemetryRecorder telemetryRecorder = new TelemetryRuntimeImpressionsRecorder(_telemetryStorageProducer);
         switch (config.impressionsMode()) {
             case OPTIMIZED:
                 ImpressionObserver impressionObserver = new ImpressionObserver(config.getLastSeenCacheSize());
                 processImpressionStrategy = new ProcessImpressionOptimized(listener != null, impressionObserver,
-                        counter, _telemetryStorageProducer);
+                        counter, telemetryRecorder);
                 break;
             case DEBUG:
                 impressionObserver = new ImpressionObserver(config.getLastSeenCacheSize());
@@ -766,7 +771,13 @@ private ImpressionsManagerImpl buildImpressionsManager(SplitClientConfig config,
                 processImpressionStrategy = processImpressionNone;
                 break;
         }
-        return ImpressionsManagerImpl.instance(config, _telemetryStorageProducer, impressionsStorageConsumer,
+        ImpressionsManagerConfig impressionsManagerConfig = ImpressionsManagerConfig.builder()
+                .mode(config.impressionsMode())
+                .impressionsRefreshRateSeconds(config.impressionsRefreshRate())
+                .threadFactory(config.getThreadFactory())
+                .debugEnabled(config.debugEnabled())
+                .build();
+        return ImpressionsManagerImpl.instance(impressionsManagerConfig, telemetryRecorder, impressionsStorageConsumer,
                 impressionsStorageProducer,
                 _impressionsSender, processImpressionNone, processImpressionStrategy, counter, listener);
     }
@@ -809,7 +820,7 @@ private UniqueKeysTracker createUniqueKeysTracker(SplitClientConfig config) {
         int uniqueKeysRefreshRate = config.operationMode().equals(OperationMode.STANDALONE)
                 ? config.uniqueKeysRefreshRateInMemory()
                 : config.uniqueKeysRefreshRateRedis();
-        return new UniqueKeysTrackerImp(_telemetrySynchronizer, uniqueKeysRefreshRate,
+        return new UniqueKeysTrackerImp(new TelemetryUniqueKeysSender(_telemetrySynchronizer), uniqueKeysRefreshRate,
                 config.filterUniqueKeysRefreshRate(),
                 config.getThreadFactory());
     }

client/src/main/java/io/split/client/impressions/TelemetryRuntimeImpressionsRecorder.java

@@ -0,0 +1,23 @@
+package io.split.client.impressions;
+
+import io.split.telemetry.domain.enums.ImpressionsDataTypeEnum;
+import io.split.telemetry.storage.TelemetryRuntimeProducer;
+
+public class TelemetryRuntimeImpressionsRecorder implements ImpressionsTelemetryRecorder {
+
+    private final TelemetryRuntimeProducer _telemetryRuntimeProducer;
+
+    public TelemetryRuntimeImpressionsRecorder(TelemetryRuntimeProducer telemetryRuntimeProducer) {
+        _telemetryRuntimeProducer = telemetryRuntimeProducer;
+    }
+
+    @Override
+    public void recordImpressionsDropped(long count) {
+        _telemetryRuntimeProducer.recordImpressionStats(ImpressionsDataTypeEnum.IMPRESSIONS_DROPPED, count);
+    }
+
+    @Override
+    public void recordImpressionsQueued(long count) {
+        _telemetryRuntimeProducer.recordImpressionStats(ImpressionsDataTypeEnum.IMPRESSIONS_QUEUED, count);
+    }
+}

client/src/main/java/io/split/client/impressions/TelemetryUniqueKeysSender.java

@@ -0,0 +1,18 @@
+package io.split.client.impressions;
+
+import io.split.client.dtos.UniqueKeys;
+import io.split.telemetry.synchronizer.TelemetrySynchronizer;
+
+public class TelemetryUniqueKeysSender implements UniqueKeysSender {
+
+    private final TelemetrySynchronizer _telemetrySynchronizer;
+
+    public TelemetryUniqueKeysSender(TelemetrySynchronizer telemetrySynchronizer) {
+        _telemetrySynchronizer = telemetrySynchronizer;
+    }
+
+    @Override
+    public void send(UniqueKeys uniqueKeys) {
+        _telemetrySynchronizer.synchronizeUniqueKeys(uniqueKeys);
+    }
+}

client/src/test/java/io/split/client/impressions/UniqueKeysTrackerImpTest.java

@@ -6,22 +6,18 @@
 import io.split.client.impressions.Impression;
 import io.split.client.impressions.ImpressionObserver;
 import io.split.client.impressions.ImpressionsResult;
-import io.split.telemetry.storage.InMemoryTelemetryStorage;
-import io.split.telemetry.storage.TelemetryStorage;
 import org.junit.Assert;
 import org.junit.Test;
-import org.mockito.Mockito;
 
 import java.util.ArrayList;
 import java.util.List;
 
 public class ProcessImpressionDebugTest {
 
     private static final long LAST_SEEN_CACHE_SIZE = 500000;
-    private static TelemetryStorage TELEMETRY_STORAGE = Mockito.mock(InMemoryTelemetryStorage.class);
 
     @Test
-    public void processImpressionsWithListener(){
+    public void processImpressionsWithListener() {
         boolean listenerEnable = true;
         ImpressionObserver impressionObserver = new ImpressionObserver(LAST_SEEN_CACHE_SIZE);
         ProcessImpressionDebug processImpressionDebug = new ProcessImpressionDebug(listenerEnable, impressionObserver);
@@ -40,12 +36,12 @@ public void processImpressionsWithListener(){
         long pt3 = impressionsResult1.getImpressionsToQueue().get(2).pt();
         Assert.assertEquals(1, pt3);
 
-        Assert.assertEquals(3,impressionsResult1.getImpressionsToQueue().size());
-        Assert.assertEquals(3,impressionsResult1.getImpressionsToListener().size());
+        Assert.assertEquals(3, impressionsResult1.getImpressionsToQueue().size());
+        Assert.assertEquals(3, impressionsResult1.getImpressionsToListener().size());
     }
 
     @Test
-    public void processImpressionsWithoutListener(){
+    public void processImpressionsWithoutListener() {
         boolean listenerEnable = false;
         ImpressionObserver impressionObserver = new ImpressionObserver(LAST_SEEN_CACHE_SIZE);
         ProcessImpressionDebug processImpressionDebug = new ProcessImpressionDebug(listenerEnable, impressionObserver);
@@ -64,7 +60,7 @@ public void processImpressionsWithoutListener(){
         long pt3 = impressionsResult1.getImpressionsToQueue().get(2).pt();
         Assert.assertEquals(1, pt3);
 
-        Assert.assertEquals(3,impressionsResult1.getImpressionsToQueue().size());
+        Assert.assertEquals(3, impressionsResult1.getImpressionsToQueue().size());
         Assert.assertNull(impressionsResult1.getImpressionsToListener());
     }
-}
+}