Validate Parameter in setPostAuthenticationChecks#19277
Open
big-cir wants to merge 1 commit into
Open
Conversation
The null check in setPostAuthenticationChecks of AbstractUserDetailsReactiveAuthenticationManager asserted the current field value, which is initialized to a default and can never be null, instead of the method parameter. As a result, null was silently accepted and the next authenticate call failed with a raw NullPointerException instead of failing fast with a clear message. Closes spring-projectsgh-19276 Signed-off-by: dae won <eodnjs01477@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The null check in
AbstractUserDetailsReactiveAuthenticationManager#setPostAuthenticationChecksasserts the current field value instead of the method parameter:Since the field is initialized to a default and can never be null at that point, the assertion always passes and
nullis silently accepted. The nextauthenticate(...)call then fails with a rawNullPointerExceptionat.doOnNext(this.postAuthenticationChecks::check)instead of failing fast with a clear message:All other setters in the same class (
setPasswordEncoder,setScheduler,setUserDetailsPasswordService,setMessageSource) validate the parameter. This change fixes the assertion to validate the parameter and adds a regression test.Related Issue
Closes gh-19276