Drop the parameter from createOwnerCluster instead of suppressing unparam

Author: Herbaert

controller/controller_test_helpers_test.go

@@ -73,12 +73,9 @@ func createCloudInitSecret(ctx context.Context, name, namespace, key, value stri
 	Expect(k8sClient.Create(ctx, secret)).To(Succeed())
 }
 
-// Every caller passes the same namespace. This is fine for testing.
-//
-//nolint:unparam
-func createOwnerCluster(ctx context.Context, name, namespace string) {
+func createOwnerCluster(ctx context.Context, name string) {
 	cluster := &clusterv1.Cluster{
-		ObjectMeta: metav1.ObjectMeta{Name: name, Namespace: namespace},
+		ObjectMeta: metav1.ObjectMeta{Name: name, Namespace: "default"},
 		Spec: clusterv1.ClusterSpec{
 			InfrastructureRef: clusterv1.ContractVersionedObjectReference{
 				APIGroup: infrav1.GroupVersion.Group,

controller/stackitcluster_controller_test.go

@@ -60,7 +60,7 @@ var _ = Describe("StackitCluster Controller", func() {
 		}
 
 		createCredentialsSecret(ctx, credentials, namespace, testProjectID)
-		createOwnerCluster(ctx, clusterName, namespace)
+		createOwnerCluster(ctx, clusterName)
 		stackitClust = newStackitCluster(clusterName, namespace, true)
 		stackitClust.Spec.CredentialsSecretRef.Name = credentials
 		Expect(k8sClient.Create(ctx, stackitClust)).To(Succeed())
@@ -208,7 +208,7 @@ var _ = Describe("StackitCluster Controller", func() {
 		// balancer was gated on its spec flag. A bastion created without its
 		// status patch landing (process restart, conflict) therefore skipped
 		// cleanup entirely and leaked server, public IP and security group.
-		createOwnerCluster(ctx, clusterName+"-nolb", namespace)
+		createOwnerCluster(ctx, clusterName+"-nolb")
 		defer deleteIfExists(ctx, &clusterv1.Cluster{
 			ObjectMeta: metav1.ObjectMeta{Name: clusterName + "-nolb", Namespace: namespace},
 		})
@@ -251,7 +251,7 @@ var _ = Describe("StackitCluster Controller", func() {
 		// disappears first during namespace teardown. Broadening the delete gate
 		// to spec.Bastion.Enabled made a working cloud client mandatory for every
 		// bastion cluster, which would strand such a cluster in Terminating.
-		createOwnerCluster(ctx, clusterName+"-nocreds", namespace)
+		createOwnerCluster(ctx, clusterName+"-nocreds")
 		defer deleteIfExists(ctx, &clusterv1.Cluster{
 			ObjectMeta: metav1.ObjectMeta{Name: clusterName + "-nocreds", Namespace: namespace},
 		})

controller/stackitmachine_controller_test.go

@@ -67,7 +67,7 @@ var _ = Describe("StackitMachine Controller", func() {
 		}
 
 		createCredentialsSecret(ctx, credentials, namespace, testProjectID)
-		createOwnerCluster(ctx, clusterName, namespace)
+		createOwnerCluster(ctx, clusterName)
 		createReadyStackitCluster(ctx, clusterName, namespace, credentials)
 		createOwnerMachine(ctx, machineName, namespace, clusterName, stackitName, nil)
 		stackitMach = newStackitMachine(stackitName, namespace, machineName)