From 4fc8ac3548ac191396ea0a0b9e88321845561d26 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 22 Sep 2026 06:27:08 +0000 Subject: [PATCH] test: migrate `stats/base/dists/uniform/median` to ULP-based assertions Replace relative tolerance comparisons with `isAlmostSameValue` ULP difference assertions in `test.js` and `test.native.js`. Both the JavaScript and C implementations reproduce the Julia fixtures exactly, so the minimum required ULP bound is 0. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01H7wkNLFGNTxtsRbFVDWC6b --- .../stats/base/dists/uniform/median/test/test.js | 13 ++----------- .../base/dists/uniform/median/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/uniform/median/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/uniform/median/test/test.js index 237c60bae3a2..5199a7d2d5b3 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/uniform/median/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/uniform/median/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var median = require( './../lib' ); @@ -72,8 +71,6 @@ tape( 'if provided `a >= b`, the function returns `NaN`', function test( t ) { tape( 'the function returns the median of a uniform distribution', function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -84,13 +81,7 @@ tape( 'the function returns the median of a uniform distribution', function test b = data.b; for ( i = 0; i < expected.length; i++ ) { y = median( a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/uniform/median/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/uniform/median/test/test.native.js index 48bcb0f440fa..f3097d4379a8 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/uniform/median/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/uniform/median/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -83,8 +82,6 @@ tape( 'if provided `a >= b`, the function returns `NaN`', opts, function test( t tape( 'the function returns the median of a uniform distribution', opts, function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -95,13 +92,7 @@ tape( 'the function returns the median of a uniform distribution', opts, functio b = data.b; for ( i = 0; i < expected.length; i++ ) { y = median( a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); });