Skip to content

Conversation

@fpistm
Copy link
Member

@fpistm fpistm commented Dec 8, 2025

Fixes #2871

@fpistm fpistm added this to the 2.12.0 milestone Dec 8, 2025
@fpistm fpistm requested a review from Copilot December 8, 2025 16:08
@fpistm fpistm added the fix 🩹 Bug fix label Dec 8, 2025
@fpistm fpistm changed the title Fpv5 fix: Cortex-M33 FPU is the FPv5 Dec 8, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CMSIS dependency from version 5.9.0 to 6.2.0 and separates CMSIS-DSP (1.16.2) and CMSIS-NN (7.0.0) as independent dependencies. The changes also correct FPU configuration for Cortex-M33 processors from fpv4-sp-d16 to fpv5-sp-d16.

Key changes:

  • Migrates from CMSIS 5 to CMSIS 6 with separated DSP and NN modules
  • Updates FPU architecture flags for Cortex-M33 boards
  • Adds backward compatibility checks for new CMSIS 6 macro names

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
platform.txt Updates CMSIS version references and separates DSP/NN path variables
libraries/SrcWrapper/src/stm32/dwt.c Adds compatibility layer for CMSIS 6 uppercase macro naming convention
libraries/CMSIS_DSP/src/WindowFunctions/WindowFunctions.c Adds wrapper to include CMSIS-DSP WindowFunctions source
libraries/CMSIS_DSP/CMakeLists.txt Registers WindowFunctions wrapper in CMake build
cmake/set_base_arduino_config.cmake Updates CMSIS path references for version 6
cmake/ensure_core_deps.cmake Adds CMSIS_DSP and CMSIS_NN as separate dependencies with download logic
boards.txt Corrects FPU architecture from fpv4 to fpv5 for Cortex-M33 boards
CI/update/stm32wrapper.py Updates CMSIS version constant and adjusts DSP source path logic
Comments suppressed due to low confidence (2)

boards.txt:1

  • Incomplete FPU architecture specification. Should be 'fpv5-sp-d16' to match other Cortex-M33 boards, not 'fpv-sp-d16'.
# See: https://arduino.github.io/arduino-cli/latest/platform-specification/

boards.txt:1

  • Incomplete FPU architecture specification. Should be 'fpv5-sp-d16' to match other Cortex-M33 boards, not 'fpv-sp-d16'.
# See: https://arduino.github.io/arduino-cli/latest/platform-specification/

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Fixes stm32duino#2871.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm merged commit c80f4a5 into stm32duino:main Dec 9, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in STM32 core based on ST HAL Dec 9, 2025
@fpistm fpistm deleted the fpv5 branch December 9, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 🩹 Bug fix

Projects

Development

Successfully merging this pull request may close these issues.

cortex-m33 variants should use build.fpu=-mfpu=fpv5-sp-d16 instead of fpv4-sp-d16

2 participants