From a174177be98cbc077b7dc258246d468034041d68 Mon Sep 17 00:00:00 2001 From: Vojtech Trefny Date: Thu, 20 Aug 2026 16:40:24 +0200 Subject: [PATCH] misc: Use ansible_facts instead of deprecated top-level fact variables Ansible deprecated the injected top-level ansible_* fact variables (e.g. ansible_distribution) in favour of accessing them through the ansible_facts dictionary. Co-Authored-By: Claude Opus 4.8 --- misc/libbytesize-tasks.yml | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/misc/libbytesize-tasks.yml b/misc/libbytesize-tasks.yml index ad4f590..facc0c9 100644 --- a/misc/libbytesize-tasks.yml +++ b/misc/libbytesize-tasks.yml @@ -12,15 +12,15 @@ - libtool - autoconf - automake - when: ansible_distribution == 'Fedora' + when: ansible_facts['distribution'] == 'Fedora' - name: Install dnf-plugins-core for dnf builddep (Fedora) package: name=dnf-plugins-core state=present - when: ansible_distribution == 'Fedora' + when: ansible_facts['distribution'] == 'Fedora' - name: Install build dependencies (Fedora) command: "dnf -y builddep libbytesize --nogpgcheck" - when: ansible_distribution == 'Fedora' + when: ansible_facts['distribution'] == 'Fedora' - name: Install test dependencies (Fedora) package: @@ -31,7 +31,7 @@ - python3-pocketlint - python3-pylint - python3-pycodestyle - when: ansible_distribution == 'Fedora' + when: ansible_facts['distribution'] == 'Fedora' ##### CentOS - name: Install basic build tools (CentOS) @@ -43,15 +43,15 @@ - libtool - autoconf - automake - when: ansible_distribution == 'CentOS' + when: ansible_facts['distribution'] == 'CentOS' - name: Install dnf-plugins-core for dnf builddep (CentOS) package: name=dnf-plugins-core state=present - when: ansible_distribution == 'CentOS' + when: ansible_facts['distribution'] == 'CentOS' - name: Install build dependencies (CentOS) command: "dnf -y builddep libbytesize --nogpgcheck" - when: ansible_distribution == 'CentOS' + when: ansible_facts['distribution'] == 'CentOS' - name: Install test dependencies (CentOS) package: @@ -59,13 +59,13 @@ name: - glibc-all-langpacks - python3-pip - when: ansible_distribution == 'CentOS' + when: ansible_facts['distribution'] == 'CentOS' - name: Install pylint, polib, pycodestyle and pocketlint using pip (CentOS) pip: name: ['pylint', 'pycodestyle', 'polib', 'pocketlint'] executable: pip3 - when: ansible_distribution == 'CentOS' + when: ansible_facts['distribution'] == 'CentOS' ##### Debian/Ubuntu - name: Install basic build tools (Debian/Ubuntu) @@ -74,22 +74,22 @@ name: - gcc - make - when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu' + when: ansible_facts['distribution'] == 'Debian' or ansible_facts['distribution'] == 'Ubuntu' - name: Add source repositories (Debian/Ubuntu) shell: "grep '^deb ' /etc/apt/sources.list | perl -pe 's/deb /deb-src /' >> /etc/apt/sources.list" - when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu' + when: ansible_facts['distribution'] == 'Debian' or ansible_facts['distribution'] == 'Ubuntu' - name: Update apt cache (Debian/Ubuntu) apt: update_cache: yes - when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu' + when: ansible_facts['distribution'] == 'Debian' or ansible_facts['distribution'] == 'Ubuntu' - name: Install build dependencies (Debian/Ubuntu) apt: name: libbytesize state: build-dep - when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu' + when: ansible_facts['distribution'] == 'Debian' or ansible_facts['distribution'] == 'Ubuntu' - name: Install test dependencies (Debian/Ubuntu) package: @@ -100,11 +100,11 @@ - python3-pip - pycodestyle - pylint - when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu' + when: ansible_facts['distribution'] == 'Debian' or ansible_facts['distribution'] == 'Ubuntu' - name: Install pocketlint using pip (Debian/Ubuntu) pip: name: ['pocketlint'] executable: pip3 extra_args: --break-system-packages - when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu' + when: ansible_facts['distribution'] == 'Debian' or ansible_facts['distribution'] == 'Ubuntu'