refactor: split HaStateController responsibilities into NavigationController by stuart-c-ai · Pull Request #406 · stuart-c/addon-eink

stuart-c-ai · 2026-04-24T22:14:18Z

This PR refactors HaStateController.ts by extracting its navigation and selection responsibilities into a dedicated NavigationController.

Key changes:

Created NavigationController to manage active section, view mode, and selection IDs.
NavigationController handles URL hash synchronization.
HaStateController now delegates navigation state to NavigationController.
HaStateController maintains backward compatibility by providing getters/setters for navigation properties.
Updated AppRoot to instantiate both controllers.
Added comprehensive tests for NavigationController and updated HaStateController tests.

stuart-c-ai enabled auto-merge April 24, 2026 22:14

github-actions Bot added chore frontend python Pull requests that update python code labels Apr 24, 2026

stuart-c previously approved these changes Apr 25, 2026

View reviewed changes

stuart-c removed the python Pull requests that update python code label Apr 25, 2026

stuart-c-ai dismissed stuart-c’s stale review via 8a14dc9 April 25, 2026 08:09

stuart-c-ai force-pushed the refactor/hastate-navigation branch from 8a14dc9 to 056a748 Compare April 25, 2026 08:30

github-actions Bot added the python Pull requests that update python code label Apr 25, 2026

stuart-c-ai force-pushed the refactor/hastate-navigation branch 5 times, most recently from a2fcfa2 to b18b3d7 Compare April 26, 2026 09:39

shimonenator added 4 commits April 26, 2026 11:11

Refactor HaStateController and stabilize navigation refactor

4382cfb

fix: stabilize E2E tests and improve controller reactivity

b143e16

fix: TypeScript compilation errors for state-changed events

241816d

fix: add missing mock method dispatchEvent for unit tests

23ceb39

stuart-c-ai force-pushed the refactor/hastate-navigation branch from 24659cd to 23ceb39 Compare April 26, 2026 10:12

Provide feedback