From b3bda79c6da2b0ed35ed45d8356d17ca1afc4ba4 Mon Sep 17 00:00:00 2001
From: Bassam Khouri <bkhouri@apple.com>
Date: Wed, 26 Nov 2025 15:45:19 -0500
Subject: [PATCH] Augment JSON ABI

Add tags, bug and timeLimit traits to the test ABI JSON data.
---
 Documentation/ABI/JSON.md                     | 13 ++++++-
 .../Testing/ABI/Encoded/ABI.EncodedTest.swift | 36 +++++++++++++++----
 Sources/Testing/Traits/Tags/Tag.swift         |  4 +--
 Tests/TestingTests/SwiftPMTests.swift         | 31 ++++++++++++++--
 4 files changed, 72 insertions(+), 12 deletions(-)

diff --git a/Documentation/ABI/JSON.md b/Documentation/ABI/JSON.md
index e4ff24a4b..71d4f7a5b 100644
--- a/Documentation/ABI/JSON.md
+++ b/Documentation/ABI/JSON.md
@@ -157,10 +157,21 @@ additional `"testCases"` field describing the individual test cases.
   ["displayName": <string>,] ; the user-supplied custom display name
   "sourceLocation": <source-location>, ; where the test is defined
   "id": <test-id>,
-  "isParameterized": <bool> ; is this a parameterized test function or not?
+  "isParameterized": <bool>, ; is this a parameterized test function or not?
+  ["tags": <array:tag>,] ; the tags associated with this test function
+  ["bugs": <array:bug>,] ; the bugs associated with this test function
+  ["timeLimit": <number>] ; the time limit associated with this test function
 }
 
 <test-id> ::= <string> ; an opaque string representing the test case
+
+<tag> ::= "." <string> ; a string representation of a tag
+
+<bug> ::= {
+  ["url": <string>,] ; the bug URL
+  ["id": <string>,] ; the bug id
+  ["title": <string>] ; the human readable bug title
+} ;
 ```
 
 <!--
diff --git a/Sources/Testing/ABI/Encoded/ABI.EncodedTest.swift b/Sources/Testing/ABI/Encoded/ABI.EncodedTest.swift
index 43a1b615b..28069c980 100644
--- a/Sources/Testing/ABI/Encoded/ABI.EncodedTest.swift
+++ b/Sources/Testing/ABI/Encoded/ABI.EncodedTest.swift
@@ -1,7 +1,7 @@
 //
 // This source file is part of the Swift.org open source project
 //
-// Copyright (c) 2024 Apple Inc. and the Swift project authors
+// Copyright (c) 2024-2025 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See https://swift.org/LICENSE.txt for license information
@@ -75,8 +75,24 @@ extension ABI {
 
     /// The tags associated with the test.
     ///
-    /// - Warning: Tags are not yet part of the JSON schema.
-    var _tags: [String]?
+    /// @Metadata {
+    ///   @Available(Swift, introduced: 6.3)
+    /// }
+    var tags: Set<Tag>?
+
+    /// The bugs associated with the test.
+    ///
+    /// @Metadata {
+    ///   @Available(Swift, introduced: 6.3)
+    /// }
+    var bugs: [Bug]?
+
+    /// The time limits associated with the test.
+    ///
+    /// @Metadata {
+    ///   @Available(Swift, introduced: 6.3)
+    /// }
+    var timeLimit: Double?
 
     init(encoding test: borrowing Test) {
       if test.isSuite {
@@ -95,10 +111,18 @@ extension ABI {
         if isParameterized == true {
           _testCases = test.uncheckedTestCases?.map(EncodedTestCase.init(encoding:))
         }
+      }
 
-        let tags = test.tags
-        if !tags.isEmpty {
-          _tags = tags.map(String.init(describing:))
+      if V.versionNumber >= ABI.v6_3.versionNumber {
+        self.tags = test.tags
+        // From version 6.3 onwards, bugs are included as an experimental
+        // field.
+        let bugs = test.traits.compactMap { $0 as? Bug }
+        if !bugs.isEmpty {
+          self.bugs = bugs
+        }
+        if #available(_clockAPI , *) {
+          self.timeLimit = test.timeLimit.map(TimeValue.init).map(Double.init)
         }
       }
     }
diff --git a/Sources/Testing/Traits/Tags/Tag.swift b/Sources/Testing/Traits/Tags/Tag.swift
index 0562622e1..e8652a6b8 100644
--- a/Sources/Testing/Traits/Tags/Tag.swift
+++ b/Sources/Testing/Traits/Tags/Tag.swift
@@ -94,10 +94,10 @@ extension Tag: Codable, CodingKeyRepresentable {
   }
 
   /// This instance represented as a string, suitable for encoding.
-  private var _codableStringValue: String {
+  package var _codableStringValue: String {
     switch kind {
     case let .staticMember(name):
-      ".\(name)"
+      "\(name)"
     }
   }
 
diff --git a/Tests/TestingTests/SwiftPMTests.swift b/Tests/TestingTests/SwiftPMTests.swift
index 2d7001e8f..3f7f05f35 100644
--- a/Tests/TestingTests/SwiftPMTests.swift
+++ b/Tests/TestingTests/SwiftPMTests.swift
@@ -377,9 +377,19 @@ struct SwiftPMTests {
     defer {
       _ = remove(temporaryFilePath)
     }
+    let testTimeLimit = 3
+    let expectedArgs = ["argument1", "argument2"]
     do {
       let configuration = try configurationForEntryPoint(withArguments: ["PATH", outputArgumentName, temporaryFilePath, versionArgumentName, "\(version.versionNumber)"])
-      let test = Test(.tags(.blue)) {}
+      let test = Test(
+        .tags(.blue),
+        .bug("https://my.defect.com/1234"),
+        .bug("other defect"),
+        .timeLimit(Swift.Duration.seconds(testTimeLimit + 100)),
+        .timeLimit(Swift.Duration.seconds(testTimeLimit)),
+        .timeLimit(Swift.Duration.seconds(testTimeLimit + 10)),
+        arguments: expectedArgs as [String]
+      ) {arg1 in}
       let eventContext = Event.Context(test: test, testCase: nil, configuration: nil)
 
       configuration.handleEvent(Event(.testDiscovered, testID: test.id, testCaseID: nil), in: eventContext)
@@ -403,10 +413,25 @@ struct SwiftPMTests {
     #expect(testRecords.count == 1)
     for testRecord in testRecords {
       if version.includesExperimentalFields {
-        #expect(testRecord._tags != nil)
+        let actualTestCases = testRecord._testCases
+        let testCases = try #require(actualTestCases)
+        #expect(testCases.count == expectedArgs.count)
       } else {
-        #expect(testRecord._tags == nil)
+        #expect(testRecord._testCases == nil)
       }
+
+      if version.versionNumber >= ABI.v6_3.versionNumber {
+        let testTags = try #require(testRecord.tags)
+        #expect(testTags.count >= 1)
+        for tag in testTags {
+          #expect(!tag._codableStringValue.starts(with: "."))
+        }
+        let bugs = try #require(testRecord.bugs)
+        #expect(bugs.count == 2)
+        let timeLimit = try #require(testRecord.timeLimit)
+        #expect(timeLimit == Double(testTimeLimit))
+      }
+
     }
     let eventRecords = decodedRecords.compactMap { record in
       if case let .event(event) = record.kind {