Benchmarks: pass iterations without globals

Author: kateinoigakukun

Benchmarks/run.js

@@ -271,9 +271,11 @@ function saveJsonResults(filePath, data) {
 /**
  * Run a single benchmark iteration
  * @param {Object} results - Results object to store benchmark data
+ * @param {(name: string) => boolean} nameFilter - Name filter
+ * @param {number} iterations - Loop iterations per JS benchmark
  * @returns {Promise<void>}
  */
-async function singleRun(results, nameFilter) {
+async function singleRun(results, nameFilter, iterations) {
     const options = await defaultNodeSetup({})
     const benchmarkRunner = (name, body) => {
         if (nameFilter && !nameFilter(name)) {
@@ -304,7 +306,6 @@ async function singleRun(results, nameFilter) {
     exports.run();
 
     const enumRoundtrip = new exports.EnumRoundtrip();
-    const iterations = globalThis.__benchIterations ?? 100_000;
     benchmarkRunner("EnumRoundtrip/takeEnum success", () => {
         for (let i = 0; i < iterations; i++) {
             enumRoundtrip.take({ tag: APIResult.Tag.Success, param0: "Hello, world" })
@@ -645,9 +646,10 @@ async function singleRun(results, nameFilter) {
  * Run until the coefficient of variation of measurements is below the threshold
  * @param {Object} results - Benchmark results object
  * @param {Object} options - Adaptive sampling options
+ * @param {number} iterations - Loop iterations per JS benchmark
  * @returns {Promise<void>}
  */
-async function runUntilStable(results, options, width, nameFilter, filterArg) {
+async function runUntilStable(results, options, width, nameFilter, filterArg, iterations) {
     const {
         minRuns = 5,
         maxRuns = 50,
@@ -666,7 +668,7 @@ async function runUntilStable(results, options, width, nameFilter, filterArg) {
         // Update progress with estimated completion
         updateProgress(runs, maxRuns, "Benchmark Progress:", width);
 
-        await singleRun(results, nameFilter);
+        await singleRun(results, nameFilter, iterations);
         runs++;
 
         if (runs === 1 && Object.keys(results).length === 0) {
@@ -772,7 +774,6 @@ async function main() {
         console.error('Invalid --iterations value:', args.values.iterations);
         process.exit(1);
     }
-    globalThis.__benchIterations = iterations;
 
     if (args.values.adaptive) {
         // Adaptive sampling mode
@@ -787,7 +788,7 @@ async function main() {
             console.log(`Results will be saved to: ${args.values.output}`);
         }
 
-        await runUntilStable(results, options, width, nameFilter, filterArg);
+        await runUntilStable(results, options, width, nameFilter, filterArg, iterations);
     } else {
         // Fixed number of runs mode
         const runs = parseInt(args.values.runs, 10);
@@ -809,7 +810,7 @@ async function main() {
         console.log("\nOverall Progress:");
         for (let i = 0; i < runs; i++) {
             updateProgress(i, runs, "Benchmark Runs:", width);
-            await singleRun(results, nameFilter);
+            await singleRun(results, nameFilter, iterations);
             if (i === 0 && Object.keys(results).length === 0) {
                 process.stdout.write("\n");
                 console.error(`No benchmarks matched filter: ${filterArg}`);