Skip to content

Commit f781c22

Browse files
committed
minor #32786 add parameter type declarations to private methods (xabbuh)
This PR was merged into the 4.4 branch. Discussion ---------- add parameter type declarations to private methods | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 1b2aaa4a06 add parameter type declarations to private methods
2 parents 74b45bd + d45caf6 commit f781c22

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

Filesystem.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -294,13 +294,11 @@ public function rename($origin, $target, $overwrite = false)
294294
/**
295295
* Tells whether a file exists and is readable.
296296
*
297-
* @param string $filename Path to the file
298-
*
299297
* @return bool
300298
*
301299
* @throws IOException When windows path is longer than 258 characters
302300
*/
303-
private function isReadable($filename)
301+
private function isReadable(string $filename)
304302
{
305303
$maxPathLength = PHP_MAXPATHLEN - 2;
306304

@@ -381,11 +379,9 @@ public function hardlink($originFile, $targetFiles)
381379
}
382380

383381
/**
384-
* @param string $origin
385-
* @param string $target
386382
* @param string $linkType Name of the link type, typically 'symbolic' or 'hard'
387383
*/
388-
private function linkException($origin, $target, $linkType)
384+
private function linkException(string $origin, string $target, string $linkType)
389385
{
390386
if (self::$lastError) {
391387
if ('\\' === \DIRECTORY_SEPARATOR && false !== strpos(self::$lastError, 'error code(1314)')) {

0 commit comments

Comments
 (0)