minor #765 Don't warn about npm/yarn unless there is a ux-package in vendor/ (nicolas-grekas)

This PR was merged into the 1.12-dev branch.

Discussion
----------

Don't warn about npm/yarn unless there is a ux-package in vendor/

A lighter version of #737

Commits
-------

9b26932 Don't warn about npm/yarn unless there is a ux-package in vendor/

Author: nicolas-grekas

src/Flex.php

@@ -591,9 +591,11 @@ private function synchronizePackageJson(?string $rootDir)
         if ($synchronizer->shouldSynchronize()) {
             $packagesNames = array_column($this->composer->getLocker()->getLockData()['packages'] ?? [], 'name');
 
-            $this->io->writeError('<info>Synchronizing package.json with PHP packages</>');
-            $synchronizer->synchronize($packagesNames);
-            $this->io->writeError('Don\'t forget to run <comment>npm install --force</> or <comment>yarn install --force</> to refresh your JavaScript dependencies!');
+            if ($synchronizer->synchronize($packagesNames)) {
+                $this->io->writeError('<info>Synchronizing package.json with PHP packages</>');
+                $this->io->writeError('<warning>Don\'t forget to run npm install --force or yarn install --force to refresh your JavaScript dependencies!</>');
+                $this->io->writeError('');
+            }
         }
     }
 

src/PackageJsonSynchronizer.php

@@ -32,21 +32,24 @@ public function shouldSynchronize(): bool
         return $this->rootDir && file_exists($this->rootDir.'/package.json');
     }
 
-    public function synchronize(array $packagesNames)
+    public function synchronize(array $packagesNames): bool
     {
         // Remove all links and add again only the existing packages
-        $this->removePackageJsonLinks((new JsonFile($this->rootDir.'/package.json'))->read());
+        $didAddLink = $this->removePackageJsonLinks((new JsonFile($this->rootDir.'/package.json'))->read());
 
         foreach ($packagesNames as $packageName) {
-            $this->addPackageJsonLink($packageName);
+            $didAddLink = $this->addPackageJsonLink($packageName) || $didAddLink;
         }
 
         // Register controllers and entrypoints in controllers.json
         $this->registerWebpackResources($packagesNames);
+
+        return $didAddLink;
     }
 
-    private function removePackageJsonLinks(array $packageJson)
+    private function removePackageJsonLinks(array $packageJson): bool
     {
+        $didRemoveLink = false;
         $jsDependencies = $packageJson['dependencies'] ?? [];
         $jsDevDependencies = $packageJson['devDependencies'] ?? [];
 
@@ -59,14 +62,17 @@ private function removePackageJsonLinks(array $packageJson)
                 $manipulator = new JsonManipulator(file_get_contents($this->rootDir.'/package.json'));
                 $manipulator->removeSubNode('devDependencies', $name);
                 file_put_contents($this->rootDir.'/package.json', $manipulator->getContents());
+                $didRemoveLink = true;
             }
         }
+
+        return $didRemoveLink;
     }
 
-    private function addPackageJsonLink(string $phpPackage)
+    private function addPackageJsonLink(string $phpPackage): bool
     {
         if (!$assetsDir = $this->resolveAssetsDir($phpPackage)) {
-            return;
+            return false;
         }
 
         $manipulator = new JsonManipulator(file_get_contents($this->rootDir.'/package.json'));
@@ -79,6 +85,8 @@ private function addPackageJsonLink(string $phpPackage)
         $manipulator->addMainKey('devDependencies', $devDependencies);
 
         file_put_contents($this->rootDir.'/package.json', $manipulator->getContents());
+
+        return true;
     }
 
     private function registerWebpackResources(array $phpPackages)