bug #728 fix package sorting (garak)

This PR was merged into the 1.9-dev branch.

Discussion
----------

fix package sorting

This should fix #726

Commits
-------

7ed5bfa fix package sorting

Author: nicolas-grekas

src/PackageJsonSynchronizer.php

@@ -63,6 +63,15 @@ private function removePackageJsonLinks(array $packageJson)
         }
     }
 
+    private static function sortPackages(JsonManipulator $manipulator, $subNode)
+    {
+        $content = json_decode($manipulator->getContents(), true);
+        $subNodeContent = $content[$subNode];
+        ksort($subNodeContent);
+
+        return json_encode([$subNode => $subNodeContent]);
+    }
+
     private function addPackageJsonLink(string $phpPackage)
     {
         if (!$assetsDir = $this->resolveAssetsDir($phpPackage)) {
@@ -71,7 +80,7 @@ private function addPackageJsonLink(string $phpPackage)
 
         $manipulator = new JsonManipulator(file_get_contents($this->rootDir.'/package.json'));
         $manipulator->addSubNode('devDependencies', '@'.$phpPackage, 'file:vendor/'.$phpPackage.$assetsDir);
-        file_put_contents($this->rootDir.'/package.json', $manipulator->getContents());
+        file_put_contents($this->rootDir.'/package.json', self::sortPackages($manipulator, 'devDependencies'));
     }
 
     private function registerWebpackResources(array $phpPackages)

tests/PackageJsonSynchronizerTest.php

@@ -65,9 +65,9 @@ public function testSynchronizeExistingPackage()
         $this->assertSame(
             [
                 'devDependencies' => [
+                    '@symfony/existing-package' => 'file:vendor/symfony/existing-package/Resources/assets',
                     '@symfony/stimulus-bridge' => '^1.0.0',
                     'stimulus' => '^1.1.1',
-                    '@symfony/existing-package' => 'file:vendor/symfony/existing-package/Resources/assets',
                 ],
             ],
             json_decode(file_get_contents($this->tempDir.'/package.json'), true)
@@ -101,10 +101,10 @@ public function testSynchronizeNewPackage()
         $this->assertSame(
             [
                 'devDependencies' => [
-                    '@symfony/stimulus-bridge' => '^1.0.0',
-                    'stimulus' => '^1.1.1',
                     '@symfony/existing-package' => 'file:vendor/symfony/existing-package/Resources/assets',
                     '@symfony/new-package' => 'file:vendor/symfony/new-package/assets',
+                    '@symfony/stimulus-bridge' => '^1.0.0',
+                    'stimulus' => '^1.1.1',
                 ],
             ],
             json_decode(file_get_contents($this->tempDir.'/package.json'), true)