feature #757 Deprecate symfony:generate-id as it's not used anymore (and remove the id everywhere) (fabpot)

This PR was merged into the 1.12-dev branch.

Discussion
----------

Deprecate symfony:generate-id as it's not used anymore (and remove the id everywhere)

Commits
-------

9ee1ee7 Deprecate symfony:generate-id as it's not used anymore

Author: fabpot

src/Command/GenerateIdCommand.php

@@ -14,29 +14,20 @@
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Style\SymfonyStyle;
 
 class GenerateIdCommand extends Command
 {
-    private $flex;
-
-    public function __construct(/* cannot be type-hinted */ $flex)
-    {
-        $this->flex = $flex;
-
-        parent::__construct();
-    }
-
     protected function configure()
     {
-        $this->setName('symfony:generate-id')
-            ->setDescription('Generates a unique ID for this project.')
-        ;
+        $this->setName('symfony:generate-id');
     }
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $this->flex->generateFlexId();
+        $ui = new SymfonyStyle($input, $output);
+        $ui->error('This command is a noop and should not be used anymore.');
 
-        return 0;
+        return 1;
     }
 }

src/Downloader.php

@@ -38,7 +38,6 @@ class Downloader
     private $degradedMode = false;
     private $endpoint;
     private $caFile;
-    private $flexId;
     private $enabled = true;
 
     public function __construct(Composer $composer, IoInterface $io, $rfs)
@@ -60,11 +59,6 @@ public function getSessionId(): string
         return $this->sess;
     }
 
-    public function setFlexId(string $id = null)
-    {
-        $this->flexId = $id;
-    }
-
     public function isEnabled()
     {
         return $this->enabled;
@@ -314,10 +308,6 @@ private function getOptions(array $headers): array
     {
         $options = ['http' => ['header' => $headers]];
 
-        if ($this->flexId) {
-            $options['http']['header'][] = 'Project: '.$this->flexId;
-        }
-
         if (null !== $this->caFile) {
             $options['ssl']['cafile'] = $this->caFile;
         }

src/Flex.php

@@ -126,7 +126,6 @@ class_exists(__NAMESPACE__.str_replace('/', '\\', substr($file, \strlen(__DIR__)
             $rfs = Factory::createHttpDownloader($this->io, $this->config);
 
             $this->downloader = $downloader = new Downloader($composer, $io, $rfs);
-            $this->downloader->setFlexId($this->getFlexId());
 
             if ($symfonyRequire) {
                 $this->filter = new PackageFilter($io, $symfonyRequire, $this->downloader);
@@ -138,7 +137,6 @@ class_exists(__NAMESPACE__.str_replace('/', '\\', substr($file, \strlen(__DIR__)
             $this->rfs = $rfs = new ParallelDownloader($this->io, $this->config, $rfs->getOptions(), $rfs->isTlsDisabled());
 
             $this->downloader = $downloader = new Downloader($composer, $io, $this->rfs);
-            $this->downloader->setFlexId($this->getFlexId());
 
             $rootPackage = $composer->getPackage();
             $manager = RepositoryFactory::manager($this->io, $this->config, $composer->getEventDispatcher(), $this->rfs);
@@ -741,24 +739,6 @@ public function onFileDownload(PreFileDownloadEvent $event)
         }
     }
 
-    public function generateFlexId()
-    {
-        if ($this->getFlexId()) {
-            return;
-        }
-
-        if (!$this->downloader->isEnabled()) {
-            throw new \LogicException('Cannot generate project id when "symfony/flex" is not found in the root composer.json.');
-        }
-
-        $json = new JsonFile(Factory::getComposerFile());
-        $manipulator = new JsonManipulator(file_get_contents($json->getPath()));
-        $manipulator->addSubNode('extra', 'symfony.id', $this->downloader->get('/ulid')->getBody()['ulid']);
-        file_put_contents($json->getPath(), $manipulator->getContents());
-
-        $this->updateComposerLock();
-    }
-
     public function updateAutoloadFile()
     {
         if (!$platform = $this->lock->get('php')['version'] ?? null) {
@@ -904,13 +884,6 @@ private function initOptions(): Options
         return new Options($options, $this->io);
     }
 
-    private function getFlexId()
-    {
-        $extra = $this->composer->getPackage()->getExtra();
-
-        return $extra['symfony']['id'] ?? null;
-    }
-
     private function formatOrigin(string $origin): string
     {
         // symfony/translation:3.3@github.com/symfony/recipes:branch