Enable the fixer enforcing fully-qualified calls for compiler-optimized functions

stof · stof · commit 5e9bf3956b27 · 2018-07-24T12:05:38.000+02:00
diff --git a/Authentication/SimpleAuthenticationHandler.php b/Authentication/SimpleAuthenticationHandler.php
@@ -55,7 +55,7 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token)
     {
         if ($this->simpleAuthenticator instanceof AuthenticationSuccessHandlerInterface) {
             if ($this->logger) {
-                $this->logger->debug('Selected an authentication success handler.', array('handler' => get_class($this->simpleAuthenticator)));
+                $this->logger->debug('Selected an authentication success handler.', array('handler' => \get_class($this->simpleAuthenticator)));
             }
 
             $response = $this->simpleAuthenticator->onAuthenticationSuccess($request, $token);
@@ -64,7 +64,7 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token)
             }
 
             if (null !== $response) {
-                throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null to use the default success handler, or a Response object', get_class($this->simpleAuthenticator)));
+                throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null to use the default success handler, or a Response object', \get_class($this->simpleAuthenticator)));
             }
         }
 
@@ -82,7 +82,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
     {
         if ($this->simpleAuthenticator instanceof AuthenticationFailureHandlerInterface) {
             if ($this->logger) {
-                $this->logger->debug('Selected an authentication failure handler.', array('handler' => get_class($this->simpleAuthenticator)));
+                $this->logger->debug('Selected an authentication failure handler.', array('handler' => \get_class($this->simpleAuthenticator)));
             }
 
             $response = $this->simpleAuthenticator->onAuthenticationFailure($request, $exception);
@@ -91,7 +91,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
             }
 
             if (null !== $response) {
-                throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null to use the default failure handler, or a Response object', get_class($this->simpleAuthenticator)));
+                throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null to use the default failure handler, or a Response object', \get_class($this->simpleAuthenticator)));
             }
         }
 
diff --git a/Firewall/ContextListener.php b/Firewall/ContextListener.php
@@ -47,7 +47,7 @@ public function __construct(TokenStorageInterface $tokenStorage, array $userProv
 
         foreach ($userProviders as $userProvider) {
             if (!$userProvider instanceof UserProviderInterface) {
-                throw new \InvalidArgumentException(sprintf('User provider "%s" must implement "Symfony\Component\Security\Core\User\UserProviderInterface".', get_class($userProvider)));
+                throw new \InvalidArgumentException(sprintf('User provider "%s" must implement "Symfony\Component\Security\Core\User\UserProviderInterface".', \get_class($userProvider)));
             }
         }
 
@@ -150,15 +150,15 @@ protected function refreshUser(TokenInterface $token)
                 $token->setUser($refreshedUser);
 
                 if (null !== $this->logger) {
-                    $this->logger->debug('User was reloaded from a user provider.', array('username' => $refreshedUser->getUsername(), 'provider' => get_class($provider)));
+                    $this->logger->debug('User was reloaded from a user provider.', array('username' => $refreshedUser->getUsername(), 'provider' => \get_class($provider)));
                 }
 
                 return $token;
             } catch (UnsupportedUserException $e) {
                 // let's try the next user provider
             } catch (UsernameNotFoundException $e) {
                 if (null !== $this->logger) {
-                    $this->logger->warning('Username could not be found in the selected user provider.', array('username' => $e->getUsername(), 'provider' => get_class($provider)));
+                    $this->logger->warning('Username could not be found in the selected user provider.', array('username' => $e->getUsername(), 'provider' => \get_class($provider)));
                 }
 
                 $userNotFoundByProvider = true;
@@ -169,7 +169,7 @@ protected function refreshUser(TokenInterface $token)
             return null;
         }
 
-        throw new \RuntimeException(sprintf('There is no user provider for user "%s".', get_class($user)));
+        throw new \RuntimeException(sprintf('There is no user provider for user "%s".', \get_class($user)));
     }
 
     private function safelyUnserialize($serializedToken)
diff --git a/Firewall/DigestAuthenticationListener.php b/Firewall/DigestAuthenticationListener.php
@@ -207,7 +207,7 @@ public function validateAndDecode($entryPointKey, $expectedRealm)
 
         $nonceTokens = explode(':', $nonceAsPlainText);
 
-        if (2 !== count($nonceTokens)) {
+        if (2 !== \count($nonceTokens)) {
             throw new BadCredentialsException(sprintf('Nonce should have yielded two tokens but was "%s".', $nonceAsPlainText));
         }
 
diff --git a/Firewall/SimplePreAuthenticationListener.php b/Firewall/SimplePreAuthenticationListener.php
@@ -83,7 +83,7 @@ public function handle(GetResponseEvent $event)
         $request = $event->getRequest();
 
         if (null !== $this->logger) {
-            $this->logger->info('Attempting SimplePreAuthentication.', array('key' => $this->providerKey, 'authenticator' => get_class($this->simpleAuthenticator)));
+            $this->logger->info('Attempting SimplePreAuthentication.', array('key' => $this->providerKey, 'authenticator' => \get_class($this->simpleAuthenticator)));
         }
 
         if (null !== $this->tokenStorage->getToken() && !$this->tokenStorage->getToken() instanceof AnonymousToken) {
@@ -112,15 +112,15 @@ public function handle(GetResponseEvent $event)
             $this->tokenStorage->setToken(null);
 
             if (null !== $this->logger) {
-                $this->logger->info('SimplePreAuthentication request failed.', array('exception' => $e, 'authenticator' => get_class($this->simpleAuthenticator)));
+                $this->logger->info('SimplePreAuthentication request failed.', array('exception' => $e, 'authenticator' => \get_class($this->simpleAuthenticator)));
             }
 
             if ($this->simpleAuthenticator instanceof AuthenticationFailureHandlerInterface) {
                 $response = $this->simpleAuthenticator->onAuthenticationFailure($request, $e);
                 if ($response instanceof Response) {
                     $event->setResponse($response);
                 } elseif (null !== $response) {
-                    throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null or a Response object', get_class($this->simpleAuthenticator)));
+                    throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null or a Response object', \get_class($this->simpleAuthenticator)));
                 }
             }
 
@@ -132,7 +132,7 @@ public function handle(GetResponseEvent $event)
             if ($response instanceof Response) {
                 $event->setResponse($response);
             } elseif (null !== $response) {
-                throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null or a Response object', get_class($this->simpleAuthenticator)));
+                throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null or a Response object', \get_class($this->simpleAuthenticator)));
             }
         }
     }
diff --git a/Firewall/UsernamePasswordFormAuthenticationListener.php b/Firewall/UsernamePasswordFormAuthenticationListener.php
@@ -110,7 +110,7 @@ protected function attemptAuthentication(Request $request)
 
         $username = trim($username);
 
-        if (strlen($username) > Security::MAX_USERNAME_LENGTH) {
+        if (\strlen($username) > Security::MAX_USERNAME_LENGTH) {
             throw new BadCredentialsException('Invalid username.');
         }
 
diff --git a/RememberMe/AbstractRememberMeServices.php b/RememberMe/AbstractRememberMeServices.php
@@ -60,7 +60,7 @@ public function __construct(array $userProviders, $secret, $providerKey, array $
         if (empty($providerKey)) {
             throw new \InvalidArgumentException('$providerKey must not be empty.');
         }
-        if (0 === count($userProviders)) {
+        if (0 === \count($userProviders)) {
             throw new \InvalidArgumentException('You must provide at least one user provider.');
         }
 
diff --git a/RememberMe/PersistentTokenBasedRememberMeServices.php b/RememberMe/PersistentTokenBasedRememberMeServices.php
@@ -67,7 +67,7 @@ protected function cancelCookie(Request $request)
 
         // Delete cookie from the tokenProvider
         if (null !== ($cookie = $request->cookies->get($this->options['name']))
-            && 2 === count($parts = $this->decodeCookie($cookie))
+            && 2 === \count($parts = $this->decodeCookie($cookie))
         ) {
             list($series) = $parts;
             $this->tokenProvider->deleteTokenBySeries($series);
@@ -79,7 +79,7 @@ protected function cancelCookie(Request $request)
      */
     protected function processAutoLoginCookie(array $cookieParts, Request $request)
     {
-        if (2 !== count($cookieParts)) {
+        if (2 !== \count($cookieParts)) {
             throw new AuthenticationException('The cookie is invalid.');
         }
 
@@ -121,7 +121,7 @@ protected function onLoginSuccess(Request $request, Response $response, TokenInt
 
         $this->tokenProvider->createNewToken(
             new PersistentToken(
-                get_class($user = $token->getUser()),
+                \get_class($user = $token->getUser()),
                 $user->getUsername(),
                 $series,
                 $tokenValue,
diff --git a/RememberMe/TokenBasedRememberMeServices.php b/RememberMe/TokenBasedRememberMeServices.php
@@ -31,7 +31,7 @@ class TokenBasedRememberMeServices extends AbstractRememberMeServices
      */
     protected function processAutoLoginCookie(array $cookieParts, Request $request)
     {
-        if (4 !== count($cookieParts)) {
+        if (4 !== \count($cookieParts)) {
             throw new AuthenticationException('The cookie is invalid.');
         }
 
@@ -50,7 +50,7 @@ protected function processAutoLoginCookie(array $cookieParts, Request $request)
         }
 
         if (!$user instanceof UserInterface) {
-            throw new \RuntimeException(sprintf('The UserProviderInterface implementation must return an instance of UserInterface, but returned "%s".', get_class($user)));
+            throw new \RuntimeException(sprintf('The UserProviderInterface implementation must return an instance of UserInterface, but returned "%s".', \get_class($user)));
         }
 
         if (true !== hash_equals($this->generateCookieHash($class, $username, $expires, $user->getPassword()), $hash)) {
@@ -71,7 +71,7 @@ protected function onLoginSuccess(Request $request, Response $response, TokenInt
     {
         $user = $token->getUser();
         $expires = time() + $this->options['lifetime'];
-        $value = $this->generateCookieValue(get_class($user), $user->getUsername(), $expires, $user->getPassword());
+        $value = $this->generateCookieValue(\get_class($user), $user->getUsername(), $expires, $user->getPassword());
 
         $response->headers->setCookie(
             new Cookie(
diff --git a/Tests/RememberMe/AbstractRememberMeServicesTest.php b/Tests/RememberMe/AbstractRememberMeServicesTest.php
@@ -304,7 +304,7 @@ protected function getProvider()
 
     private function callProtected($object, $method, array $args)
     {
-        $reflection = new \ReflectionClass(get_class($object));
+        $reflection = new \ReflectionClass(\get_class($object));
         $reflectionMethod = $reflection->getMethod($method);
         $reflectionMethod->setAccessible(true);
 

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token)`
`55`	`55`	`{`
`56`	`56`	`if ($this->simpleAuthenticator instanceof AuthenticationSuccessHandlerInterface) {`
`57`	`57`	`if ($this->logger) {`
`58`		`- $this->logger->debug('Selected an authentication success handler.', array('handler' => get_class($this->simpleAuthenticator)));`
	`58`	`+ $this->logger->debug('Selected an authentication success handler.', array('handler' => \get_class($this->simpleAuthenticator)));`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`$response = $this->simpleAuthenticator->onAuthenticationSuccess($request, $token);`
`@@ -64,7 +64,7 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token)`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`if (null !== $response) {`
`67`		`- throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null to use the default success handler, or a Response object', get_class($this->simpleAuthenticator)));`
	`67`	`+ throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null to use the default success handler, or a Response object', \get_class($this->simpleAuthenticator)));`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`
`@@ -82,7 +82,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio`
`82`	`82`	`{`
`83`	`83`	`if ($this->simpleAuthenticator instanceof AuthenticationFailureHandlerInterface) {`
`84`	`84`	`if ($this->logger) {`
`85`		`- $this->logger->debug('Selected an authentication failure handler.', array('handler' => get_class($this->simpleAuthenticator)));`
	`85`	`+ $this->logger->debug('Selected an authentication failure handler.', array('handler' => \get_class($this->simpleAuthenticator)));`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`$response = $this->simpleAuthenticator->onAuthenticationFailure($request, $exception);`
`@@ -91,7 +91,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`if (null !== $response) {`
`94`		`- throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null to use the default failure handler, or a Response object', get_class($this->simpleAuthenticator)));`
	`94`	`+ throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null to use the default failure handler, or a Response object', \get_class($this->simpleAuthenticator)));`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function __construct(TokenStorageInterface $tokenStorage, array $userProv`
`47`	`47`
`48`	`48`	`foreach ($userProviders as $userProvider) {`
`49`	`49`	`if (!$userProvider instanceof UserProviderInterface) {`
`50`		`- throw new \InvalidArgumentException(sprintf('User provider "%s" must implement "Symfony\Component\Security\Core\User\UserProviderInterface".', get_class($userProvider)));`
	`50`	`+ throw new \InvalidArgumentException(sprintf('User provider "%s" must implement "Symfony\Component\Security\Core\User\UserProviderInterface".', \get_class($userProvider)));`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`
`@@ -150,15 +150,15 @@ protected function refreshUser(TokenInterface $token)`
`150`	`150`	`$token->setUser($refreshedUser);`
`151`	`151`
`152`	`152`	`if (null !== $this->logger) {`
`153`		`- $this->logger->debug('User was reloaded from a user provider.', array('username' => $refreshedUser->getUsername(), 'provider' => get_class($provider)));`
	`153`	`+ $this->logger->debug('User was reloaded from a user provider.', array('username' => $refreshedUser->getUsername(), 'provider' => \get_class($provider)));`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`return $token;`
`157`	`157`	`} catch (UnsupportedUserException $e) {`
`158`	`158`	`// let's try the next user provider`
`159`	`159`	`} catch (UsernameNotFoundException $e) {`
`160`	`160`	`if (null !== $this->logger) {`
`161`		`- $this->logger->warning('Username could not be found in the selected user provider.', array('username' => $e->getUsername(), 'provider' => get_class($provider)));`
	`161`	`+ $this->logger->warning('Username could not be found in the selected user provider.', array('username' => $e->getUsername(), 'provider' => \get_class($provider)));`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`$userNotFoundByProvider = true;`
`@@ -169,7 +169,7 @@ protected function refreshUser(TokenInterface $token)`
`169`	`169`	`return null;`
`170`	`170`	`}`
`171`	`171`
`172`		`- throw new \RuntimeException(sprintf('There is no user provider for user "%s".', get_class($user)));`
	`172`	`+ throw new \RuntimeException(sprintf('There is no user provider for user "%s".', \get_class($user)));`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`private function safelyUnserialize($serializedToken)`
Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ public function validateAndDecode($entryPointKey, $expectedRealm)`
`207`	`207`
`208`	`208`	`$nonceTokens = explode(':', $nonceAsPlainText);`
`209`	`209`
`210`		`- if (2 !== count($nonceTokens)) {`
	`210`	`+ if (2 !== \count($nonceTokens)) {`
`211`	`211`	`throw new BadCredentialsException(sprintf('Nonce should have yielded two tokens but was "%s".', $nonceAsPlainText));`
`212`	`212`	`}`
`213`	`213`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public function handle(GetResponseEvent $event)`
`83`	`83`	`$request = $event->getRequest();`
`84`	`84`
`85`	`85`	`if (null !== $this->logger) {`
`86`		`- $this->logger->info('Attempting SimplePreAuthentication.', array('key' => $this->providerKey, 'authenticator' => get_class($this->simpleAuthenticator)));`
	`86`	`+ $this->logger->info('Attempting SimplePreAuthentication.', array('key' => $this->providerKey, 'authenticator' => \get_class($this->simpleAuthenticator)));`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`if (null !== $this->tokenStorage->getToken() && !$this->tokenStorage->getToken() instanceof AnonymousToken) {`
`@@ -112,15 +112,15 @@ public function handle(GetResponseEvent $event)`
`112`	`112`	`$this->tokenStorage->setToken(null);`
`113`	`113`
`114`	`114`	`if (null !== $this->logger) {`
`115`		`- $this->logger->info('SimplePreAuthentication request failed.', array('exception' => $e, 'authenticator' => get_class($this->simpleAuthenticator)));`
	`115`	`+ $this->logger->info('SimplePreAuthentication request failed.', array('exception' => $e, 'authenticator' => \get_class($this->simpleAuthenticator)));`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`if ($this->simpleAuthenticator instanceof AuthenticationFailureHandlerInterface) {`
`119`	`119`	`$response = $this->simpleAuthenticator->onAuthenticationFailure($request, $e);`
`120`	`120`	`if ($response instanceof Response) {`
`121`	`121`	`$event->setResponse($response);`
`122`	`122`	`} elseif (null !== $response) {`
`123`		`- throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null or a Response object', get_class($this->simpleAuthenticator)));`
	`123`	`+ throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null or a Response object', \get_class($this->simpleAuthenticator)));`
`124`	`124`	`}`
`125`	`125`	`}`
`126`	`126`
`@@ -132,7 +132,7 @@ public function handle(GetResponseEvent $event)`
`132`	`132`	`if ($response instanceof Response) {`
`133`	`133`	`$event->setResponse($response);`
`134`	`134`	`} elseif (null !== $response) {`
`135`		`- throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null or a Response object', get_class($this->simpleAuthenticator)));`
	`135`	`+ throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null or a Response object', \get_class($this->simpleAuthenticator)));`
`136`	`136`	`}`
`137`	`137`	`}`
`138`	`138`	`}`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ protected function attemptAuthentication(Request $request)`
`110`	`110`
`111`	`111`	`$username = trim($username);`
`112`	`112`
`113`		`- if (strlen($username) > Security::MAX_USERNAME_LENGTH) {`
	`113`	`+ if (\strlen($username) > Security::MAX_USERNAME_LENGTH) {`
`114`	`114`	`throw new BadCredentialsException('Invalid username.');`
`115`	`115`	`}`
`116`	`116`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public function __construct(array $userProviders, $secret, $providerKey, array $`
`60`	`60`	`if (empty($providerKey)) {`
`61`	`61`	`throw new \InvalidArgumentException('$providerKey must not be empty.');`
`62`	`62`	`}`
`63`		`- if (0 === count($userProviders)) {`
	`63`	`+ if (0 === \count($userProviders)) {`
`64`	`64`	`throw new \InvalidArgumentException('You must provide at least one user provider.');`
`65`	`65`	`}`
`66`	`66`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class TokenBasedRememberMeServices extends AbstractRememberMeServices`
`31`	`31`	`*/`
`32`	`32`	`protected function processAutoLoginCookie(array $cookieParts, Request $request)`
`33`	`33`	`{`
`34`		`- if (4 !== count($cookieParts)) {`
	`34`	`+ if (4 !== \count($cookieParts)) {`
`35`	`35`	`throw new AuthenticationException('The cookie is invalid.');`
`36`	`36`	`}`
`37`	`37`
`@@ -50,7 +50,7 @@ protected function processAutoLoginCookie(array $cookieParts, Request $request)`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`if (!$user instanceof UserInterface) {`
`53`		`- throw new \RuntimeException(sprintf('The UserProviderInterface implementation must return an instance of UserInterface, but returned "%s".', get_class($user)));`
	`53`	`+ throw new \RuntimeException(sprintf('The UserProviderInterface implementation must return an instance of UserInterface, but returned "%s".', \get_class($user)));`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`if (true !== hash_equals($this->generateCookieHash($class, $username, $expires, $user->getPassword()), $hash)) {`
`@@ -71,7 +71,7 @@ protected function onLoginSuccess(Request $request, Response $response, TokenInt`
`71`	`71`	`{`
`72`	`72`	`$user = $token->getUser();`
`73`	`73`	`$expires = time() + $this->options['lifetime'];`
`74`		`- $value = $this->generateCookieValue(get_class($user), $user->getUsername(), $expires, $user->getPassword());`
	`74`	`+ $value = $this->generateCookieValue(\get_class($user), $user->getUsername(), $expires, $user->getPassword());`
`75`	`75`
`76`	`76`	`$response->headers->setCookie(`
`77`	`77`	`new Cookie(`
Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,7 @@ protected function getProvider()`
`304`	`304`
`305`	`305`	`private function callProtected($object, $method, array $args)`
`306`	`306`	`{`
`307`		`- $reflection = new \ReflectionClass(get_class($object));`
	`307`	`+ $reflection = new \ReflectionClass(\get_class($object));`
`308`	`308`	`$reflectionMethod = $reflection->getMethod($method);`
`309`	`309`	`$reflectionMethod->setAccessible(true);`
`310`	`310`