[Security] Deprecate simple_preauth and simple_form in favor of Guard

Author: Robin Chalas

Authentication/SimpleAuthenticationHandler.php

@@ -18,6 +18,8 @@
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Exception\AuthenticationException;
 
+@trigger_error(sprintf('The "%s" class is deprecated since Symfony 4.2, use Guard instead.', SimpleAuthenticationHandler::class), E_USER_DEPRECATED);
+
 /**
  * Class to proxy authentication success/failure handlers.
  *
@@ -26,6 +28,8 @@
  * the default handlers are triggered.
  *
  * @author Jordi Boggiano <j.boggiano@seld.be>
+ *
+ * @deprecated since Symfony 4.2, use Guard instead.
  */
 class SimpleAuthenticationHandler implements AuthenticationFailureHandlerInterface, AuthenticationSuccessHandlerInterface
 {

Authentication/SimpleFormAuthenticatorInterface.php

@@ -16,6 +16,8 @@
 
 /**
  * @author Jordi Boggiano <j.boggiano@seld.be>
+ *
+ * @deprecated since Symfony 4.2, use Guard instead.
  */
 interface SimpleFormAuthenticatorInterface extends SimpleAuthenticatorInterface
 {

Authentication/SimplePreAuthenticatorInterface.php

@@ -16,6 +16,8 @@
 
 /**
  * @author Jordi Boggiano <j.boggiano@seld.be>
+ *
+ * @deprecated since Symfony 4.2, use Guard instead.
  */
 interface SimplePreAuthenticatorInterface extends SimpleAuthenticatorInterface
 {

Firewall/SimpleFormAuthenticationListener.php

@@ -29,8 +29,12 @@
 use Symfony\Component\Security\Http\ParameterBagUtils;
 use Symfony\Component\Security\Http\Session\SessionAuthenticationStrategyInterface;
 
+@trigger_error(sprintf('The "%s" class is deprecated since Symfony 4.2, use Guard instead.', SimpleFormAuthenticationListener::class), E_USER_DEPRECATED);
+
 /**
  * @author Jordi Boggiano <j.boggiano@seld.be>
+ *
+ * @deprecated since Symfony 4.2, use Guard instead.
  */
 class SimpleFormAuthenticationListener extends AbstractAuthenticationListener
 {

Firewall/SimplePreAuthenticationListener.php

@@ -31,10 +31,14 @@
 use Symfony\Component\Security\Http\SecurityEvents;
 use Symfony\Component\Security\Http\Session\SessionAuthenticationStrategyInterface;
 
+@trigger_error(sprintf('The "%s" class is deprecated since Symfony 4.2, use Guard instead.', SimplePreAuthenticationListener::class), E_USER_DEPRECATED);
+
 /**
  * SimplePreAuthenticationListener implements simple proxying to an authenticator.
  *
  * @author Jordi Boggiano <j.boggiano@seld.be>
+ *
+ * @deprecated since Symfony 4.2, use Guard instead.
  */
 class SimplePreAuthenticationListener implements ListenerInterface
 {

Tests/Authentication/SimpleAuthenticationHandlerTest.php

@@ -19,6 +19,9 @@
 use Symfony\Component\Security\Http\Authentication\AuthenticationSuccessHandlerInterface;
 use Symfony\Component\Security\Http\Authentication\SimpleAuthenticationHandler;
 
+/**
+ * @group legacy
+ */
 class SimpleAuthenticationHandlerTest extends TestCase
 {
     private $successHandler;

Tests/Firewall/SimplePreAuthenticationListenerTest.php

@@ -18,6 +18,9 @@
 use Symfony\Component\Security\Http\Firewall\SimplePreAuthenticationListener;
 use Symfony\Component\Security\Http\SecurityEvents;
 
+/**
+ * @group legacy
+ */
 class SimplePreAuthenticationListenerTest extends TestCase
 {
     private $authenticationManager;