[HttpFoundation] make cookies auto-secure when passing them $secure=null + plan to make it and samesite=lax the defaults in 5.0

nicolas-grekas · nicolas-grekas · commit 9e0952f847d8 · 2018-09-20T08:41:35.000+02:00
diff --git a/Tests/RememberMe/ResponseListenerTest.php b/Tests/RememberMe/ResponseListenerTest.php
@@ -24,7 +24,7 @@ class ResponseListenerTest extends TestCase
 {
     public function testRememberMeCookieIsSentWithResponse()
     {
-        $cookie = new Cookie('rememberme');
+        $cookie = new Cookie('rememberme', null, 0, '/', null, false, true, false, null);
 
         $request = $this->getRequest(array(
             RememberMeServicesInterface::COOKIE_ATTR_NAME => $cookie,
@@ -39,7 +39,7 @@ public function testRememberMeCookieIsSentWithResponse()
 
     public function testRememberMeCookieIsNotSendWithResponseForSubRequests()
     {
-        $cookie = new Cookie('rememberme');
+        $cookie = new Cookie('rememberme', null, 0, '/', null, false, true, false, null);
 
         $request = $this->getRequest(array(
             RememberMeServicesInterface::COOKIE_ATTR_NAME => $cookie,

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class ResponseListenerTest extends TestCase`
`24`	`24`	`{`
`25`	`25`	`public function testRememberMeCookieIsSentWithResponse()`
`26`	`26`	`{`
`27`		`- $cookie = new Cookie('rememberme');`
	`27`	`+ $cookie = new Cookie('rememberme', null, 0, '/', null, false, true, false, null);`
`28`	`28`
`29`	`29`	`$request = $this->getRequest(array(`
`30`	`30`	`RememberMeServicesInterface::COOKIE_ATTR_NAME => $cookie,`
`@@ -39,7 +39,7 @@ public function testRememberMeCookieIsSentWithResponse()`
`39`	`39`
`40`	`40`	`public function testRememberMeCookieIsNotSendWithResponseForSubRequests()`
`41`	`41`	`{`
`42`		`- $cookie = new Cookie('rememberme');`
	`42`	`+ $cookie = new Cookie('rememberme', null, 0, '/', null, false, true, false, null);`
`43`	`43`
`44`	`44`	`$request = $this->getRequest(array(`
`45`	`45`	`RememberMeServicesInterface::COOKIE_ATTR_NAME => $cookie,`