Merge branch '3.4' into 4.1

* 3.4:
  [travis][appveyor] use symfony/flex to accelerate builds
  Add missing stderr redirection
  clean up unused code
  [Filesystem] Add test to prevent regression when using array|resource with dumpFile
  [Security] Call AccessListener after LogoutListener

Author: nicolas-grekas

Firewall.php

@@ -16,6 +16,7 @@
 use Symfony\Component\HttpKernel\Event\FinishRequestEvent;
 use Symfony\Component\HttpKernel\Event\GetResponseEvent;
 use Symfony\Component\HttpKernel\KernelEvents;
+use Symfony\Component\Security\Http\Firewall\AccessListener;
 
 /**
  * Firewall uses a FirewallMap to register security listeners for the given
@@ -49,20 +50,31 @@ public function onKernelRequest(GetResponseEvent $event)
         // register listeners for this firewall
         $listeners = $this->map->getListeners($event->getRequest());
 
-        $authenticationListeners = $listeners[0];
-        $exceptionListener = $listeners[1];
-        $logoutListener = isset($listeners[2]) ? $listeners[2] : null;
+        $accessListener = null;
+        $authenticationListeners = array();
 
-        if (null !== $exceptionListener) {
+        foreach ($listeners[0] as $listener) {
+            if ($listener instanceof AccessListener) {
+                $accessListener = $listener;
+            } else {
+                $authenticationListeners[] = $listener;
+            }
+        }
+
+        if (null !== $exceptionListener = $listeners[1]) {
             $this->exceptionListeners[$event->getRequest()] = $exceptionListener;
             $exceptionListener->register($this->dispatcher);
         }
 
-        $this->handleRequest($event, $authenticationListeners);
+        if (null !== $logoutListener = isset($listeners[2]) ? $listeners[2] : null) {
+            $authenticationListeners[] = $logoutListener;
+        }
 
-        if (null !== $logoutListener) {
-            $logoutListener->handle($event);
+        if (null !== $accessListener) {
+            $authenticationListeners[] = $accessListener;
         }
+
+        $this->handleRequest($event, $authenticationListeners);
     }
 
     public function onKernelFinishRequest(FinishRequestEvent $event)

Tests/FirewallTest.php

@@ -79,7 +79,7 @@ public function testOnKernelRequestStopsWhenThereIsAResponse()
             ->getMock()
         ;
         $event
-            ->expects($this->once())
+            ->expects($this->at(0))
             ->method('hasResponse')
             ->will($this->returnValue(true))
         ;