Merge branch '4.1'

* 4.1:
  Fix Clidumper tests
  Enable the fixer enforcing fully-qualified calls for compiler-optimized functions
  Apply fixers
  Disable the native_constant_invocation fixer until it can be scoped
  Update the list of excluded files for the CS fixer

Author: nicolas-grekas

Definition.php

@@ -90,7 +90,7 @@ private function setInitialPlace(string $place = null)
 
     private function addPlace(string $place)
     {
-        if (!count($this->places)) {
+        if (!\count($this->places)) {
             $this->initialPlace = $place;
         }
 

Dumper/PlantUmlDumper.php

@@ -89,7 +89,7 @@ public function dump(Definition $definition, Marking $marking = null, array $opt
                             "$transitionEscaped --> $toEscaped",
                         );
                         foreach ($lines as $line) {
-                            if (!in_array($line, $code)) {
+                            if (!\in_array($line, $code)) {
                                 $code[] = $line;
                             }
                         }
@@ -135,12 +135,12 @@ private function initialize(array $options): array
         if (isset($options['name'])) {
             $code[] = "title {$options['name']}";
         }
-        if (isset($options['skinparams']) && is_array($options['skinparams'])) {
+        if (isset($options['skinparams']) && \is_array($options['skinparams'])) {
             foreach ($options['skinparams'] as $skinparamKey => $skinparamValue) {
                 if (!$this->isWorkflowTransitionType() && 'agent' === $skinparamKey) {
                     continue;
                 }
-                if (!is_array($skinparamValue)) {
+                if (!\is_array($skinparamValue)) {
                     $code[] = "skinparam {$skinparamKey} $skinparamValue";
                     continue;
                 }

Event/Event.php

@@ -43,7 +43,7 @@ public function __construct($subject, Marking $marking, Transition $transition,
         if (null === $workflow) {
             @trigger_error(sprintf('Passing only three parameters to "%s" is deprecated since Symfony 4.1. Pass a %s instance as fourth parameter instead.', __METHOD__, WorkflowInterface::class), E_USER_DEPRECATED);
             $this->workflowName = 'unnamed';
-        } elseif (is_string($workflow)) {
+        } elseif (\is_string($workflow)) {
             @trigger_error(sprintf('Passing a string as the 4th parameter of "%s()" is deprecated since Symfony 4.1. Pass a %s instance instead.', __METHOD__, WorkflowInterface::class), E_USER_DEPRECATED);
             $this->workflowName = $workflow;
         } elseif ($workflow instanceof WorkflowInterface) {

EventListener/AuditTrailListener.php

@@ -30,19 +30,19 @@ public function __construct(LoggerInterface $logger)
     public function onLeave(Event $event)
     {
         foreach ($event->getTransition()->getFroms() as $place) {
-            $this->logger->info(sprintf('Leaving "%s" for subject of class "%s" in workflow "%s".', $place, get_class($event->getSubject()), $event->getWorkflowName()));
+            $this->logger->info(sprintf('Leaving "%s" for subject of class "%s" in workflow "%s".', $place, \get_class($event->getSubject()), $event->getWorkflowName()));
         }
     }
 
     public function onTransition(Event $event)
     {
-        $this->logger->info(sprintf('Transition "%s" for subject of class "%s" in workflow "%s".', $event->getTransition()->getName(), get_class($event->getSubject()), $event->getWorkflowName()));
+        $this->logger->info(sprintf('Transition "%s" for subject of class "%s" in workflow "%s".', $event->getTransition()->getName(), \get_class($event->getSubject()), $event->getWorkflowName()));
     }
 
     public function onEnter(Event $event)
     {
         foreach ($event->getTransition()->getTos() as $place) {
-            $this->logger->info(sprintf('Entering "%s" for subject of class "%s" in workflow "%s".', $place, get_class($event->getSubject()), $event->getWorkflowName()));
+            $this->logger->info(sprintf('Entering "%s" for subject of class "%s" in workflow "%s".', $place, \get_class($event->getSubject()), $event->getWorkflowName()));
         }
     }
 

EventListener/ExpressionLanguage.php

@@ -41,7 +41,7 @@ protected function registerFunctions()
 
             $errors = $variables['validator']->validate($object, null, $groups);
 
-            return 0 === count($errors);
+            return 0 === \count($errors);
         });
     }
 }

Metadata/GetMetadataTrait.php

@@ -43,6 +43,6 @@ public function getMetadata(string $key, $subject = null)
             return $metadataBag[$key] ?? null;
         }
 
-        throw new InvalidArgumentException(sprintf('Could not find a MetadataBag for the subject of type "%s".', is_object($subject) ? get_class($subject) : gettype($subject)));
+        throw new InvalidArgumentException(sprintf('Could not find a MetadataBag for the subject of type "%s".', \is_object($subject) ? \get_class($subject) : \gettype($subject)));
     }
 }

Registry.php

@@ -60,7 +60,7 @@ public function get($subject, $workflowName = null)
         }
 
         if (!$matched) {
-            throw new InvalidArgumentException(sprintf('Unable to find a workflow for class "%s".', get_class($subject)));
+            throw new InvalidArgumentException(sprintf('Unable to find a workflow for class "%s".', \get_class($subject)));
         }
 
         return $matched;

Validator/StateMachineValidator.php

@@ -24,14 +24,14 @@ public function validate(Definition $definition, $name)
         $transitionFromNames = array();
         foreach ($definition->getTransitions() as $transition) {
             // Make sure that each transition has exactly one TO
-            if (1 !== count($transition->getTos())) {
-                throw new InvalidDefinitionException(sprintf('A transition in StateMachine can only have one output. But the transition "%s" in StateMachine "%s" has %d outputs.', $transition->getName(), $name, count($transition->getTos())));
+            if (1 !== \count($transition->getTos())) {
+                throw new InvalidDefinitionException(sprintf('A transition in StateMachine can only have one output. But the transition "%s" in StateMachine "%s" has %d outputs.', $transition->getName(), $name, \count($transition->getTos())));
             }
 
             // Make sure that each transition has exactly one FROM
             $froms = $transition->getFroms();
-            if (1 !== count($froms)) {
-                throw new InvalidDefinitionException(sprintf('A transition in StateMachine can only have one input. But the transition "%s" in StateMachine "%s" has %d inputs.', $transition->getName(), $name, count($froms)));
+            if (1 !== \count($froms)) {
+                throw new InvalidDefinitionException(sprintf('A transition in StateMachine can only have one input. But the transition "%s" in StateMachine "%s" has %d inputs.', $transition->getName(), $name, \count($froms)));
             }
 
             // Enforcing uniqueness of the names of transitions starting at each node

Validator/WorkflowValidator.php

@@ -32,7 +32,7 @@ public function validate(Definition $definition, $name)
         $places = array_fill_keys($definition->getPlaces(), array());
         foreach ($definition->getTransitions() as $transition) {
             foreach ($transition->getFroms() as $from) {
-                if (in_array($transition->getName(), $places[$from])) {
+                if (\in_array($transition->getName(), $places[$from])) {
                     throw new InvalidDefinitionException(sprintf('All transitions for a place must have an unique name. Multiple transitions named "%s" where found for place "%s" in workflow "%s".', $transition->getName(), $from, $name));
                 }
                 $places[$from][] = $transition->getName();
@@ -44,8 +44,8 @@ public function validate(Definition $definition, $name)
         }
 
         foreach ($definition->getTransitions() as $transition) {
-            if (1 < count($transition->getTos())) {
-                throw new InvalidDefinitionException(sprintf('The marking store of workflow "%s" can not store many places. But the transition "%s" has too many output (%d). Only one is accepted.', $name, $transition->getName(), count($transition->getTos())));
+            if (1 < \count($transition->getTos())) {
+                throw new InvalidDefinitionException(sprintf('The marking store of workflow "%s" can not store many places. But the transition "%s" has too many output (%d). Only one is accepted.', $name, $transition->getName(), \count($transition->getTos())));
             }
         }
     }