From 8f3fcaec731a7b28af6b1751e63ac6edca01547a Mon Sep 17 00:00:00 2001
From: Pascal Brokmeier <pascal@everycure.org>
Date: Sun, 31 May 2026 19:32:07 +0200
Subject: [PATCH] fix(gemini): strip propertyNames from tool schemas

---
 crates/forge_app/src/utils.rs | 39 +++++++++++++++++++++++++++++++++--
 1 file changed, 37 insertions(+), 2 deletions(-)

diff --git a/crates/forge_app/src/utils.rs b/crates/forge_app/src/utils.rs
index eedda7ad9b..349157d793 100644
--- a/crates/forge_app/src/utils.rs
+++ b/crates/forge_app/src/utils.rs
@@ -581,6 +581,7 @@ fn normalize_gemini_schema_subset_keywords(map: &mut serde_json::Map<String, ser
         "definitions",
         "deprecated",
         "examples",
+        "propertyNames",
         "title",
         "unevaluatedItems",
         "unevaluatedProperties",
@@ -610,8 +611,8 @@ fn normalize_gemini_schema_subset_keywords(map: &mut serde_json::Map<String, ser
 ///   The `required` array is filtered to only include fields present in
 ///   `properties`.
 /// - **Unsupported JSON Schema metadata and references are rejected**:
-///   `$schema`, `$defs`, `$ref`, `title`, and `additionalProperties` are
-///   removed.
+///   `$schema`, `$defs`, `$ref`, `title`, `additionalProperties`, and
+///   `propertyNames` are removed.
 /// - **Exclusive bounds are rejected**: `exclusiveMinimum` and
 ///   `exclusiveMaximum` are converted to `minimum` and `maximum` when the
 ///   inclusive bound is not already present.
@@ -1684,6 +1685,40 @@ mod tests {
         );
     }
 
+    #[test]
+    fn test_gemini_removes_property_names() {
+        let mut schema = json!({
+            "type": "object",
+            "properties": {
+                "pages": {
+                    "type": "array",
+                    "items": {
+                        "type": "object",
+                        "properties": {
+                            "metadata": {
+                                "type": "object",
+                                "propertyNames": {
+                                    "pattern": "^[a-z]+$"
+                                }
+                            }
+                        }
+                    }
+                },
+                "config": {
+                    "type": "object",
+                    "propertyNames": {
+                        "pattern": "^[a-z]+$"
+                    }
+                }
+            }
+        });
+
+        sanitize_gemini_schema(&mut schema);
+
+        let api_request_json = serde_json::to_string(&schema).unwrap();
+        assert!(!api_request_json.contains("propertyNames"));
+    }
+
     #[test]
     fn test_gemini_converts_integer_enum_to_string() {
         let mut schema = json!({