From 189079ca14d05e18f1789cb951c021587eb7af5a Mon Sep 17 00:00:00 2001 From: Kannan Rajah Date: Sun, 6 Sep 2026 12:46:47 -0700 Subject: [PATCH 1/3] =?UTF-8?q?Bump=20protobufjs=20override=207.5.1=20?= =?UTF-8?q?=E2=86=92=207.5.2?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit @temporalio/common@1.23.0 requires protobufjs/ext/protojson which was added in protobufjs 7.5.2. The pnpm override pinning 7.5.1 causes "Cannot find module 'protobufjs/ext/protojson'" errors in all TypeScript kitchensink tests. Co-Authored-By: Claude Opus 4.6 (1M context) --- sdkbuild/typescript.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdkbuild/typescript.go b/sdkbuild/typescript.go index 2c0c7b8d..2a1befb5 100644 --- a/sdkbuild/typescript.go +++ b/sdkbuild/typescript.go @@ -151,7 +151,7 @@ func BuildTypeScriptProgram(ctx context.Context, options BuildTypeScriptProgramO }, "pnpm": { "overrides": { - "protobufjs": "7.5.1" + "protobufjs": "7.5.2" } } }` From 15ef0828834afb53fef72fa0a11e34faf6c5c9b6 Mon Sep 17 00:00:00 2001 From: Kannan Rajah Date: Sun, 6 Sep 2026 12:52:13 -0700 Subject: [PATCH 2/3] Fix: bump protobufjs override to ^8.7.1 (not 7.5.2) @temporalio/common@1.23.0 declares protobufjs@^8.7.1 as a dependency. The ext/protojson module was added in protobufjs 8.6.0, so bumping to 7.5.2 would not have fixed the issue. Co-Authored-By: Claude Opus 4.6 (1M context) --- sdkbuild/typescript.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdkbuild/typescript.go b/sdkbuild/typescript.go index 2a1befb5..a76cb0a3 100644 --- a/sdkbuild/typescript.go +++ b/sdkbuild/typescript.go @@ -151,7 +151,7 @@ func BuildTypeScriptProgram(ctx context.Context, options BuildTypeScriptProgramO }, "pnpm": { "overrides": { - "protobufjs": "7.5.2" + "protobufjs": "^8.7.1" } } }` From d9beeb487aa8aa01aa1e98c123c213d3f2762e0a Mon Sep 17 00:00:00 2001 From: Kannan Rajah Date: Sun, 6 Sep 2026 12:57:16 -0700 Subject: [PATCH 3/3] Also bump protobufjs in root package.json MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The pin exists in two places — the pnpm override in sdkbuild (for external consumers like omes) and the root package.json (for the features repo's own TS tests). Both need ^8.7.1. Co-Authored-By: Claude Opus 4.6 (1M context) --- package-lock.json | 56 +++++++++++++++++++++++++++++++++++++---------- package.json | 2 +- 2 files changed, 46 insertions(+), 12 deletions(-) diff --git a/package-lock.json b/package-lock.json index 1d262c93..abd93d05 100644 --- a/package-lock.json +++ b/package-lock.json @@ -25,7 +25,7 @@ "ms": "^3.0.0-canary.1", "nexus-rpc": "^0.0.1", "proto3-json-serializer": "^1.1.1", - "protobufjs": "7.5.1" + "protobufjs": "^8.7.1" }, "devDependencies": { "@tsconfig/node24": "^24.0.4", @@ -1744,6 +1744,29 @@ "node": ">=14.0.0" } }, + "node_modules/@temporalio/common/node_modules/protobufjs": { + "version": "7.6.6", + "resolved": "https://registry.npmjs.org/protobufjs/-/protobufjs-7.6.6.tgz", + "integrity": "sha512-dYDWdjSl5RNb7SgPxGQcRU+GtvP7s2fpkrY0r432PcOIaZ0/rBcxEZnQN67iJhFuQiVw754JDoPruPCNdGsbjg==", + "hasInstallScript": true, + "license": "BSD-3-Clause", + "dependencies": { + "@protobufjs/aspromise": "^1.1.2", + "@protobufjs/base64": "^1.1.2", + "@protobufjs/codegen": "^2.0.5", + "@protobufjs/eventemitter": "^1.1.1", + "@protobufjs/fetch": "^1.1.1", + "@protobufjs/float": "^1.0.2", + "@protobufjs/path": "^1.1.2", + "@protobufjs/pool": "^1.1.0", + "@protobufjs/utf8": "^1.1.1", + "@types/node": ">=13.7.0", + "long": "^5.3.2" + }, + "engines": { + "node": ">=12.0.0" + } + }, "node_modules/@temporalio/core-bridge": { "version": "1.21.1", "resolved": "https://registry.npmjs.org/@temporalio/core-bridge/-/core-bridge-1.21.1.tgz", @@ -6082,25 +6105,36 @@ "node": ">=12.0.0" } }, - "node_modules/protobufjs": { - "version": "7.5.1", - "resolved": "https://registry.npmjs.org/protobufjs/-/protobufjs-7.5.1.tgz", - "integrity": "sha512-3qx3IRjR9WPQKagdwrKjO3Gu8RgQR2qqw+1KnigWhoVjFqegIj1K3bP11sGqhxrO46/XL7lekuG4jmjL+4cLsw==", + "node_modules/proto3-json-serializer/node_modules/protobufjs": { + "version": "7.6.6", + "resolved": "https://registry.npmjs.org/protobufjs/-/protobufjs-7.6.6.tgz", + "integrity": "sha512-dYDWdjSl5RNb7SgPxGQcRU+GtvP7s2fpkrY0r432PcOIaZ0/rBcxEZnQN67iJhFuQiVw754JDoPruPCNdGsbjg==", "hasInstallScript": true, "license": "BSD-3-Clause", "dependencies": { "@protobufjs/aspromise": "^1.1.2", "@protobufjs/base64": "^1.1.2", - "@protobufjs/codegen": "^2.0.4", - "@protobufjs/eventemitter": "^1.1.0", - "@protobufjs/fetch": "^1.1.0", + "@protobufjs/codegen": "^2.0.5", + "@protobufjs/eventemitter": "^1.1.1", + "@protobufjs/fetch": "^1.1.1", "@protobufjs/float": "^1.0.2", - "@protobufjs/inquire": "^1.1.0", "@protobufjs/path": "^1.1.2", "@protobufjs/pool": "^1.1.0", - "@protobufjs/utf8": "^1.1.0", + "@protobufjs/utf8": "^1.1.1", "@types/node": ">=13.7.0", - "long": "^5.0.0" + "long": "^5.3.2" + }, + "engines": { + "node": ">=12.0.0" + } + }, + "node_modules/protobufjs": { + "version": "8.8.0", + "resolved": "https://registry.npmjs.org/protobufjs/-/protobufjs-8.8.0.tgz", + "integrity": "sha512-N3xhQ5yyBx3vQq4gubBfASzYhJGNzeDbjqBpu61g7UVylsN/qyffU96TKWD3GbbLOKF82VGNRNvv1+BFgE31Eg==", + "license": "BSD-3-Clause", + "dependencies": { + "long": "^5.3.2" }, "engines": { "node": ">=12.0.0" diff --git a/package.json b/package.json index adeec156..1528f6f0 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,7 @@ "ms": "^3.0.0-canary.1", "nexus-rpc": "^0.0.1", "proto3-json-serializer": "^1.1.1", - "protobufjs": "7.5.1" + "protobufjs": "^8.7.1" }, "devDependencies": { "@tsconfig/node24": "^24.0.4",