removed the distinct() check from set_fit()

topepo · topepo · commit 4f82ee9cf2bb · 2019-06-05T21:18:15.000-04:00
diff --git a/R/aaa_models.R b/R/aaa_models.R
@@ -382,15 +382,11 @@ set_model_arg <- function(model, eng, parsnip, original, func, has_submodel) {
          eng, " engine. You cannot overwrite arguments.", call. = FALSE)
   }
 
-  # TODO cant currently use `distinct()` on a list column.
-  # Use `vctrs::vctrs_duplicated()` instead
   updated <- try(dplyr::bind_rows(old_args, new_arg), silent = TRUE)
   if (inherits(updated, "try-error")) {
     stop("An error occured when adding the new argument.", call. = FALSE)
   }
 
-  updated <- dplyr::distinct(updated, engine, parsnip, original, has_submodel)
-
   current[[paste0(model, "_args")]] <- updated
 
   invisible(NULL)

Original file line number	Diff line number	Diff line change
`@@ -382,15 +382,11 @@ set_model_arg <- function(model, eng, parsnip, original, func, has_submodel) {`
`382`	`382`	`eng, " engine. You cannot overwrite arguments.", call. = FALSE)`
`383`	`383`	`}`
`384`	`384`
`385`		- # TODO cant currently use `distinct()` on a list column.
`386`		- # Use `vctrs::vctrs_duplicated()` instead
`387`	`385`	`updated <- try(dplyr::bind_rows(old_args, new_arg), silent = TRUE)`
`388`	`386`	`if (inherits(updated, "try-error")) {`
`389`	`387`	`stop("An error occured when adding the new argument.", call. = FALSE)`
`390`	`388`	`}`
`391`	`389`
`392`		`- updated <- dplyr::distinct(updated, engine, parsnip, original, has_submodel)`
`393`		`-`
`394`	`390`	`current[[paste0(model, "_args")]] <- updated`
`395`	`391`
`396`	`392`	`invisible(NULL)`