From eaf5cf7f53913380e248d0caabac339375f1f8de Mon Sep 17 00:00:00 2001 From: Mattijs Borst Date: Tue, 22 Sep 2026 12:56:22 +0200 Subject: [PATCH] Remove dormant, dimensionally-incorrect diffusivity line (fixes #182) self.D was never actually computed from this commented-out line - AquiferData.initialize() already computes it correctly as self.T / self.Scoefaq (Scoefaq = Saq * Haq), which is what's used elsewhere (e.g. the eigenvalue computation). The leftover comment in __init__ used self.T / self.Saq directly, which is dimensionally wrong (Saq is specific storage [1/L], not the dimensionless/areal storage coefficient) and would also fail at runtime since self.T isn't set yet at that point in __init__. Dead code, so removing it has no functional effect - verified a model still builds, solves, and reports the same aq.D as before. Co-Authored-By: Claude Sonnet 5 --- timflow/transient/aquifer.py | 1 - 1 file changed, 1 deletion(-) diff --git a/timflow/transient/aquifer.py b/timflow/transient/aquifer.py index f788394..8cab7bf 100644 --- a/timflow/transient/aquifer.py +++ b/timflow/transient/aquifer.py @@ -84,7 +84,6 @@ def __init__( assert self.topboundary.startswith("con") or self.topboundary.startswith( "phr" ), "Error: For Model3D, only 'confined' topboundary is currently implemented." - # self.D = self.T / self.Saq self.area = 1e200 # Smaller than default of ml.aq so that inhom is found self.name = name # set reference to top boundary element for background aquifers and inhoms