chore(ruff): Linting fixes

docs/conf.py:80:89: E501 Line too long (100 > 88 characters)
docs/conf.py:81:89: E501 Line too long (628 > 88 characters)
docs/conf.py:90:88: E501 Line too long (167 > 88 characters)
src/libtmux/common.py:14:26: F401 [*] `typing.Generic` imported but unused
src/libtmux/common.py:14:35: F401 [*] `typing.KeysView` imported but unused
src/libtmux/common.py:14:45: F401 [*] `typing.List` imported but unused
src/libtmux/common.py:14:61: F401 [*] `typing.TypeVar` imported but unused
src/libtmux/common.py:14:77: F401 [*] `typing.overload` imported but unused
src/libtmux/common.py:20:35: F401 [*] `typing_extensions.Literal` imported but unused
src/libtmux/common.py:22:30: F401 [*] `libtmux.pane.Pane` imported but unused
src/libtmux/common.py:23:33: F401 [*] `libtmux.session.Session` imported but unused
src/libtmux/common.py:24:32: F401 [*] `libtmux.window.Window` imported but unused
src/libtmux/common.py:76:13: F841 [*] Local variable `stderr` is assigned to but never used
src/libtmux/common.py:100:13: F841 [*] Local variable `stderr` is assigned to but never used
src/libtmux/common.py:123:13: F841 [*] Local variable `stderr` is assigned to but never used
src/libtmux/common.py:151:20: F823 Local variable `t` referenced before assignment
src/libtmux/common.py:152:13: F402 Import `t` from line 13 shadowed by loop variable
src/libtmux/common.py:179:20: F823 Local variable `t` referenced before assignment
src/libtmux/common.py:189:13: F402 Import `t` from line 13 shadowed by loop variable
src/libtmux/pane.py:17:20: F401 [*] `.formats` imported but unused
src/libtmux/pane.py:18:21: F401 [*] `.common.PaneDict` imported but unused
Found 21 errors.

Author: tony

docs/conf.py

@@ -1,8 +1,9 @@
-# flake8: NOQA E5
+# flake8: NOQA: E501
+import contextlib
 import inspect
 import sys
-from os.path import dirname, relpath
-from pathlib import Path
+from os.path import relpath
+import pathlib
 import typing as t
 
 import libtmux  # NOQA
@@ -12,7 +13,7 @@
     from sphinx.application import Sphinx
 
 # Get the project root dir, which is the parent dir of this
-cwd = Path(__file__).parent
+cwd = pathlib.Path(__file__).parent
 project_root = cwd.parent
 project_src = project_root / "src"
 
@@ -21,7 +22,7 @@
 
 # package data
 about: t.Dict[str, str] = {}
-with open(project_src / "libtmux" / "__about__.py") as fp:
+with (project_src / "libtmux" / "__about__.py").open() as fp:
     exec(fp.read(), about)
 
 extensions = [
@@ -125,13 +126,13 @@
 ogp_desscription_length = about["__description__"]
 ogp_site_name = about["__title__"]
 
-htmlhelp_basename = "%sdoc" % about["__title__"]
+htmlhelp_basename = f"{about['__title__']}doc"
 
 latex_documents = [
     (
         "index",
-        "{}.tex".format(about["__package_name__"]),
-        "{} Documentation".format(about["__title__"]),
+        f"{about['__package_name__']}.tex",
+        f"{about['__title__']} Documentation",
         about["__author__"],
         "manual",
     )
@@ -141,7 +142,7 @@
     (
         "index",
         about["__package_name__"],
-        "{} Documentation".format(about["__title__"]),
+        f"{about['__title__']} Documentation",
         about["__author__"],
         1,
     )
@@ -150,8 +151,8 @@
 texinfo_documents = [
     (
         "index",
-        "{}".format(about["__package_name__"]),
-        "{} Documentation".format(about["__title__"]),
+        about["__package_name__"],
+        f"{about['__title__']} Documentation",
         about["__author__"],
         about["__package_name__"],
         about["__description__"],
@@ -220,7 +221,7 @@ def linkcode_resolve(
     else:
         linespec = ""
 
-    fn = relpath(fn, start=dirname(libtmux.__file__))
+    fn = relpath(fn, start=pathlib.Path(libtmux.__file__).parent)
 
     if "dev" in about["__version__"]:
         return "{}/blob/master/{}/{}/{}{}".format(
@@ -244,11 +245,9 @@ def linkcode_resolve(
 def remove_tabs_js(app: "Sphinx", exc: Exception) -> None:
     # Fix for sphinx-inline-tabs#18
     if app.builder.format == "html" and not exc:
-        tabs_js = Path(app.builder.outdir) / "_static" / "tabs.js"
-        try:
-            tabs_js.unlink()  # use missing_ok=True when python 3.7 deprecated
-        except FileNotFoundError:
-            pass
+        tabs_js = pathlib.Path(app.builder.outdir) / "_static" / "tabs.js"
+        with contextlib.suppress(FileNotFoundError):
+            tabs_js.unlink()  # When python 3.7 deprecated, use missing_ok=True
 
 
 def setup(app: "Sphinx") -> None:

src/libtmux/common.py

@@ -11,17 +11,13 @@
 import subprocess
 import sys
 import typing as t
-from typing import Dict, Generic, KeysView, List, Optional, TypeVar, Union, overload
+from typing import Dict, Optional, Union
 
 from . import exc
 from ._compat import LooseVersion, console_to_str, str_from_console
 
 if t.TYPE_CHECKING:
-    from typing_extensions import Literal
-
-    from libtmux.pane import Pane
-    from libtmux.session import Session
-    from libtmux.window import Window
+    pass
 
 
 logger = logging.getLogger(__name__)
@@ -73,7 +69,7 @@ def set_environment(self, name: str, value: str) -> None:
         cmd = self.cmd(*args)
 
         if cmd.stderr:
-            stderr = (
+            (
                 cmd.stderr[0]
                 if isinstance(cmd.stderr, list) and len(cmd.stderr) == 1
                 else cmd.stderr
@@ -97,7 +93,7 @@ def unset_environment(self, name: str) -> None:
         cmd = self.cmd(*args)
 
         if cmd.stderr:
-            stderr = (
+            (
                 cmd.stderr[0]
                 if isinstance(cmd.stderr, list) and len(cmd.stderr) == 1
                 else cmd.stderr
@@ -120,7 +116,7 @@ def remove_environment(self, name: str) -> None:
         cmd = self.cmd(*args)
 
         if cmd.stderr:
-            stderr = (
+            (
                 cmd.stderr[0]
                 if isinstance(cmd.stderr, list) and len(cmd.stderr) == 1
                 else cmd.stderr
@@ -149,13 +145,13 @@ def show_environment(self) -> Dict[str, Union[bool, str]]:
         output = cmd.stdout
         vars = [tuple(item.split("=", 1)) for item in output]
         vars_dict: t.Dict[str, t.Union[str, bool]] = {}
-        for t in vars:
-            if len(t) == 2:
-                vars_dict[t[0]] = t[1]
-            elif len(t) == 1:
-                vars_dict[t[0]] = True
+        for _t in vars:
+            if len(_t) == 2:
+                vars_dict[_t[0]] = _t[1]
+            elif len(_t) == 1:
+                vars_dict[_t[0]] = True
             else:
-                raise ValueError("unexpected variable %s", t)
+                raise ValueError(f"unexpected variable {_t}")
 
         return vars_dict
 
@@ -186,13 +182,13 @@ def getenv(self, name: str) -> Optional[t.Union[str, bool]]:
         output = cmd.stdout
         vars = [tuple(item.split("=", 1)) for item in output]
         vars_dict: t.Dict[str, t.Union[str, bool]] = {}
-        for t in vars:
-            if len(t) == 2:
-                vars_dict[t[0]] = t[1]
-            elif len(t) == 1:
-                vars_dict[t[0]] = True
+        for _t in vars:
+            if len(_t) == 2:
+                vars_dict[_t[0]] = _t[1]
+            elif len(_t) == 1:
+                vars_dict[_t[0]] = True
             else:
-                raise ValueError("unexpected variable %s", t)
+                raise ValueError(f"unexpected variable {_t}")
 
         return vars_dict.get(name)
 

src/libtmux/pane.py

@@ -14,8 +14,7 @@
 from libtmux.common import tmux_cmd
 from libtmux.neo import Obj, fetch_obj
 
-from . import exc, formats
-from .common import PaneDict
+from . import exc
 
 if t.TYPE_CHECKING:
     from typing_extensions import Literal