Skip to content

Commit e11d247

Browse files
committed
tests(refactor): Update tests to use new APIs instead of deprecated ones
why: Tests were using deprecated APIs that now raise exceptions. what: - test_dataclasses.py: resize_pane() -> resize() - test_hooks.py: attached_window/attached_pane -> active_window/active_pane - test_options.py: split_window() -> split(), test now expects DeprecatedError - test_pane.py: test_resize_pane -> test_resize, resize_pane() -> resize() - test_window.py: kill_window() -> kill(), select_pane() -> panes.get().select(), set_window_option/show_window_option -> set_option/show_option, deprecation tests now expect DeprecatedError instead of warnings
1 parent f915178 commit e11d247

File tree

5 files changed

+73
-82
lines changed

5 files changed

+73
-82
lines changed

tests/test_dataclasses.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ def test_pane(
6565

6666
old_pane_size = pane.pane_height
6767

68-
pane.resize_pane(adjustment_direction=ResizeAdjustmentDirection.Down, adjustment=25)
69-
pane.resize_pane(
68+
pane.resize(adjustment_direction=ResizeAdjustmentDirection.Down, adjustment=25)
69+
pane.resize(
7070
adjustment_direction=ResizeAdjustmentDirection.Right,
7171
adjustment=25,
7272
)

tests/test_hooks.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ def test_hooks_raw_cmd(
1919
) -> None:
2020
"""Raw hook set, show, unset via cmd."""
2121
session = server.new_session(session_name="test hooks")
22-
window = session.attached_window
23-
pane = window.attached_pane
22+
window = session.active_window
23+
pane = window.active_pane
2424
assert pane is not None
2525

2626
#
@@ -198,8 +198,8 @@ def test_hooks_dataclass(
198198
) -> None:
199199
"""Tests for hooks dataclass."""
200200
session = server.new_session(session_name="test hooks")
201-
window = session.attached_window
202-
pane = window.attached_pane
201+
window = session.active_window
202+
pane = window.active_pane
203203
assert pane is not None
204204

205205
#
@@ -277,8 +277,8 @@ def test_hooks_mixin(
277277
) -> None:
278278
"""Tests for hooks."""
279279
session = server.new_session(session_name="test hooks")
280-
window = session.attached_window
281-
pane = window.attached_pane
280+
window = session.active_window
281+
pane = window.active_pane
282282
assert pane is not None
283283

284284
pane.set_hook("session-renamed[0]", "set -g status-left-style bg=red")

tests/test_options.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from libtmux._internal.sparse_array import SparseArray
1919
from libtmux.common import has_gte_version
2020
from libtmux.constants import OptionScope
21-
from libtmux.exc import OptionError
21+
from libtmux.exc import DeprecatedError, OptionError
2222
from libtmux.options import TerminalOverrides, convert_values, explode_arrays
2323
from libtmux.pane import Pane
2424

@@ -33,7 +33,7 @@ def test_options(server: Server) -> None:
3333
"""Test basic options."""
3434
session = server.new_session(session_name="test")
3535
window = session.new_window(window_name="test")
36-
pane = window.split_window(attach=False)
36+
pane = window.split(attach=False)
3737

3838
for obj in [server, session, window, pane]:
3939
obj._show_options()
@@ -60,7 +60,7 @@ def test_options_server(server: Server) -> None:
6060
"""Test server options."""
6161
session = server.new_session(session_name="test")
6262
window = session.new_window(window_name="test")
63-
pane = window.split_window(attach=False)
63+
pane = window.split(attach=False)
6464

6565
server.set_option("buffer-limit", 100)
6666
assert server._show_option("buffer-limit") == 100
@@ -122,7 +122,7 @@ def test_options_window(server: Server) -> None:
122122
"""Test window options."""
123123
session = server.new_session(session_name="test")
124124
window = session.new_window(window_name="test")
125-
window.split_window(attach=False)
125+
window.split(attach=False)
126126

127127
window_options_ = window._show_options(scope=OptionScope.Window)
128128

@@ -134,7 +134,7 @@ def test_options_pane(server: Server) -> None:
134134
"""Test pane options."""
135135
session = server.new_session(session_name="test")
136136
window = session.new_window(window_name="test")
137-
pane = window.split_window(attach=False)
137+
pane = window.split(attach=False)
138138

139139
pane_options_ = pane._show_options(scope=OptionScope.Pane)
140140

@@ -146,7 +146,7 @@ def test_options_grid(server: Server) -> None:
146146
"""Test options against grid."""
147147
session = server.new_session(session_name="test")
148148
window = session.new_window(window_name="test")
149-
pane = window.split_window(attach=False)
149+
pane = window.split(attach=False)
150150

151151
for include_inherited in [True, False]:
152152
for global_ in [True, False]:
@@ -501,7 +501,7 @@ def test_show_option_pane_fixture(
501501
"""Test Pane.show_option(s)?."""
502502
session = server.new_session(session_name="test")
503503
window = session.new_window(window_name="test")
504-
pane = window.split_window(attach=False)
504+
pane = window.split(attach=False)
505505

506506
monkeypatch.setattr(pane, "cmd", fake_cmd(stdout=mocked_cmd_stdout))
507507

@@ -1351,12 +1351,12 @@ def test_convert_values_preserves_sparse_keys() -> None:
13511351
assert result[99] == 100
13521352

13531353

1354-
def test_show_option_g_parameter_emits_deprecation_warning(
1354+
def test_show_option_g_parameter_raises_deprecated_error(
13551355
session: Session,
13561356
) -> None:
1357-
"""Test show_option() emits DeprecationWarning when g parameter is used."""
1357+
"""Test show_option() raises DeprecatedError when g parameter is used."""
13581358
server = session.server
1359-
with pytest.warns(DeprecationWarning, match=r"g argument is deprecated"):
1359+
with pytest.raises(DeprecatedError, match=r"g parameter was deprecated"):
13601360
server.show_option("buffer-limit", g=True)
13611361

13621362

tests/test_pane.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -183,10 +183,10 @@ def test_pane_split_window_zoom(
183183
assert pane_with_zoom.height == pane_with_zoom.window_height
184184

185185

186-
def test_resize_pane(
186+
def test_resize(
187187
session: Session,
188188
) -> None:
189-
"""Verify resizing window."""
189+
"""Verify resizing pane."""
190190
session.cmd("detach-client", "-s")
191191

192192
window = session.active_window
@@ -208,29 +208,29 @@ def test_resize_pane(
208208

209209
# Manual: Height
210210
pane_height_before = int(pane.pane_height)
211-
pane.resize_pane(
211+
pane.resize(
212212
height="50",
213213
)
214214
assert int(pane.pane_height) == 50
215215

216216
# Manual: Width
217217
window.select_layout("main-horizontal")
218-
pane.resize_pane(
218+
pane.resize(
219219
width="75",
220220
)
221221
assert int(pane.pane_width) == 75
222222

223223
# Manual: Height percentage
224224
window.select_layout("main-vertical")
225225
pane_height_before = int(pane.pane_height)
226-
pane.resize_pane(
226+
pane.resize(
227227
height="15%",
228228
)
229229
assert int(pane.pane_height) == 75
230230

231231
# Manual: Width percentage
232232
window.select_layout("main-horizontal")
233-
pane.resize_pane(
233+
pane.resize(
234234
width="15%",
235235
)
236236
assert int(pane.pane_width) == 75
@@ -241,15 +241,15 @@ def test_resize_pane(
241241

242242
# Adjustment: Down
243243
pane_height_before = int(pane.pane_height)
244-
pane.resize_pane(
244+
pane.resize(
245245
adjustment_direction=ResizeAdjustmentDirection.Down,
246246
adjustment=pane_height_adjustment * 2,
247247
)
248248
assert pane_height_before - (pane_height_adjustment * 2) == int(pane.pane_height)
249249

250250
# Adjustment: Up
251251
pane_height_before = int(pane.pane_height)
252-
pane.resize_pane(
252+
pane.resize(
253253
adjustment_direction=ResizeAdjustmentDirection.Up,
254254
adjustment=pane_height_adjustment,
255255
)
@@ -258,12 +258,12 @@ def test_resize_pane(
258258
#
259259
# Zoom
260260
#
261-
pane.resize_pane(height=50)
261+
pane.resize(height=50)
262262

263263
# Zoom
264-
pane.resize_pane(height=2)
264+
pane.resize(height=2)
265265
pane_height_before = int(pane.pane_height)
266-
pane.resize_pane(
266+
pane.resize(
267267
zoom=True,
268268
)
269269
pane_height_expanded = int(pane.pane_height)

0 commit comments

Comments
 (0)