Type hints

[aaronsteers]

Hi, I'm curious if you would accept a PR to add type hints throughout this library. I have run into numerous cases where I sent a dict or object when the vice versa was needed. Is this something you would be amenable to reviewing if I were to create a PR?

In building out the singer-sdk, I've mostly avoided dependencies on this library just because I was not confident on how types should be handled. If I had confidence in expected data types we could put more load on this library, rather than reinventing the wheel.

Thanks!

[Samira-El]

Hey Aaron.

That would be great, type hints are cool and definitely make dev life's easier! I would also suggest adding a CI check using mypy.

[aaronsteers]

@Samira-El - Awesome! And since this is going to be a large code review, any objections to an incremental approach? Perhaps I can do it all in one go, but if it gets too unwieldy I was thinking I might focus first on catalog and bookmarks.

[Samira-El]

An incremental approach sounds good and makes review easier for us!

[aaronsteers]

I got more done than I expected. 😅 #26

[aaronsteers]

@Samira-El - This is ready for review: #26