Skip to content

Commit 002a15e

Browse files
committed
fix(webapp): keep feedback dialog open for field errors
1 parent 4173b4c commit 002a15e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

apps/webapp/app/components/Feedback.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,11 @@ export function Feedback({
6666
if (
6767
navigation.formAction === "/resources/feedback" &&
6868
navigation.state === "loading" &&
69-
(form.errors === undefined || form.errors.length === 0)
69+
Object.keys(form.allErrors).length === 0
7070
) {
7171
setOpen(false);
7272
}
73-
}, [navigation, form]);
73+
}, [navigation.formAction, navigation.state, form.allErrors]);
7474

7575
// Handle URL param functionality
7676
useEffect(() => {

0 commit comments

Comments
 (0)