Skip to content

Commit 1520939

Browse files
committed
docs(run-engine): fix stale references in the CK fairness design docs
Reframe the retained findings/research headers so they no longer say 'delete before merge' (the spike harness is archived and ships nothing; the findings ship as a design reference), and replace the placeholder .server-changes/2026-XX-XX filename with the real dated file. Addresses CodeRabbit notes on the design docs.
1 parent 1425291 commit 1520939

5 files changed

Lines changed: 7 additions & 7 deletions

internal-packages/run-engine/design/plans/2026-07-23-ck-virtual-time-scheduling-plan.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ Create:
236236
assertions)
237237
- `internal-packages/run-engine/src/run-queue/tests/ckVtimeConcurrency.test.ts`
238238
(multi-consumer correctness, op-count budget)
239-
- `.server-changes/2026-XX-XX-ck-fair-scheduling.md` (at PR time; note it
239+
- `.server-changes/2026-07-24-ck-fair-scheduling.md` (at PR time; note it
240240
ships dark)
241241

242242
## Tasks
@@ -752,7 +752,7 @@ Verify: `pnpm run typecheck --filter @internal/run-engine` and
752752

753753
### Task 10: ship notes and cleanup
754754

755-
- Add `.server-changes/2026-XX-XX-ck-fair-scheduling.md` per
755+
- Add `.server-changes/2026-07-24-ck-fair-scheduling.md` per
756756
`.server-changes/README.md` (user-facing wording; it ships dark, so the
757757
note says the fair ordering exists behind a flag and changes nothing by
758758
default). No changeset (no public package touched).

internal-packages/run-engine/design/references/run-queue-fairness-base-queue-findings.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Fair-queueing spike: findings
22

3-
This is a throwaway spike. It ships nothing and should be deleted before any
4-
merge to main; it exists to inform a design decision, not to become code.
3+
Findings from a throwaway spike whose harness is archived and ships nothing; these
4+
findings are retained here as a design reference that informed the change, not as code.
55

66
Read the caveats section before quoting any single number. Two of them matter up
77
front: (1) the candidate selectors are handed tenant identity (parsed from the

internal-packages/run-engine/design/references/run-queue-fairness-caps-vs-scheduling-findings.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Caps vs scheduling: reconciliation findings
22

3-
Throwaway spike. Ships nothing; delete before any merge to main. Relative ranking
3+
Findings from a throwaway spike whose harness is archived (`chore/fair-queueing-spike`) and ships nothing; these findings are retained here as a design reference. Relative ranking
44
on a small simulation, not a statistical or load study: read the verdicts as "what
55
this harness supports", not proofs. Went through a blind two-model adversarial
66
review (a third stalled); the review's fixes are folded in below.

internal-packages/run-engine/design/references/run-queue-fairness-ck-findings.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Per-concurrency-key fairness spike: findings
22

3-
Throwaway spike. Ships nothing; delete before any merge to main.
3+
Findings from a throwaway spike whose harness is archived (`chore/fair-queueing-spike`) and ships nothing; these findings are retained here as a design reference.
44

55
Bottom line: the base-queue spike's direction carries over to the real seam. At
66
the concurrency-key grain the production baseline (serve the oldest-head CK

internal-packages/run-engine/design/references/run-queue-fairness-research.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Queue-fairness research (grounding for the caps-vs-scheduling reconciliation)
22

3-
Throwaway spike notes. Five Fable research passes, distilled. Citations kept so
3+
Research notes distilled from a throwaway spike, retained here as a design reference. Five Fable research passes, distilled. Citations kept so
44
the findings write-up and report can point at real sources. This grounds the
55
central claim: occupancy caps and fair scheduling are orthogonal knobs, and the
66
plan-of-record ships the cap knob while the earlier spike measured the scheduler

0 commit comments

Comments
 (0)