improve ecr check

nicktrn · nicktrn · commit 2eae336f6102 · 2025-07-02T16:50:20.000+01:00
diff --git a/apps/webapp/app/v3/getDeploymentImageRef.server.ts b/apps/webapp/app/v3/getDeploymentImageRef.server.ts
@@ -149,7 +149,12 @@ export async function getDeploymentImageRef({
 }
 
 export function isEcrRegistry(registryHost: string) {
-  return registryHost.includes("amazonaws.com");
+  try {
+    parseEcrRegistryDomain(registryHost);
+    return true;
+  } catch {
+    return false;
+  }
 }
 
 function parseRegistryTags(tags: string): Tag[] {

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,12 @@ export async function getDeploymentImageRef({`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`export function isEcrRegistry(registryHost: string) {`
`152`		`- return registryHost.includes("amazonaws.com");`
	`152`	`+ try {`
	`153`	`+ parseEcrRegistryDomain(registryHost);`
	`154`	`+ return true;`
	`155`	`+ } catch {`
	`156`	`+ return false;`
	`157`	`+ }`
`153`	`158`	`}`
`154`	`159`
`155`	`160`	`function parseRegistryTags(tags: string): Tag[] {`