Skip to content

Commit 4d1141f

Browse files
committed
fix: prevent silent failures when releasing stream reader locks
1 parent 61b338b commit 4d1141f

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

packages/core/src/v3/realtimeStreams/streamInstance.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,5 +153,10 @@ async function* streamToAsyncIterator<T>(stream: ReadableStream<T>): AsyncIterab
153153
function safeReleaseLock(reader: ReadableStreamDefaultReader<any>) {
154154
try {
155155
reader.releaseLock();
156-
} catch (error) {}
156+
} catch (error) {
157+
if (debug) {
158+
// fallback if no logger available
159+
console.warn("Failed to release stream reader lock", error);
160+
}
161+
}
157162
}

packages/core/src/v3/realtimeStreams/streamsWriterV1.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,5 +464,10 @@ async function* streamToAsyncIterator<T>(stream: ReadableStream<T>): AsyncIterab
464464
function safeReleaseLock(reader: ReadableStreamDefaultReader<any>) {
465465
try {
466466
reader.releaseLock();
467-
} catch (error) {}
467+
} catch (error) {
468+
if (debug) {
469+
// fallback if no logger available
470+
console.warn("Failed to release stream reader lock", error);
471+
}
472+
}
468473
}

packages/core/src/v3/realtimeStreams/streamsWriterV2.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,5 +212,10 @@ async function* streamToAsyncIterator<T>(stream: ReadableStream<T>): AsyncIterab
212212
function safeReleaseLock(reader: ReadableStreamDefaultReader<any>) {
213213
try {
214214
reader.releaseLock();
215-
} catch (error) {}
215+
} catch (error) {
216+
if (debug) {
217+
// fallback if no logger available
218+
console.warn("Failed to release stream reader lock", error);
219+
}
220+
}
216221
}

0 commit comments

Comments
 (0)