fix: prevent large root/parent metadata updates from endlessly retrying (#2290)

* fixing metadata WIP

* WIP

* fix: prevent large root/parent metadata updates from endlessly retrying

* Fixed other calls to handleMetadataPacket

Author: ericallam

apps/webapp/app/routes/api.v1.runs.$runId.metadata.ts

@@ -2,9 +2,9 @@ import { json } from "@remix-run/server-runtime";
 import { tryCatch } from "@trigger.dev/core/utils";
 import { UpdateMetadataRequestBody } from "@trigger.dev/core/v3";
 import { z } from "zod";
-import { updateMetadataService } from "~/services/metadata/updateMetadata.server";
+import { updateMetadataService } from "~/services/metadata/updateMetadataInstance.server";
 import { createActionApiRoute } from "~/services/routeBuilders/apiBuilder.server";
-import { ServiceValidationError } from "~/v3/services/baseService.server";
+import { ServiceValidationError } from "~/v3/services/common.server";
 
 const ParamsSchema = z.object({
   runId: z.string(),

apps/webapp/app/runEngine/services/triggerTask.server.ts

@@ -46,6 +46,7 @@ export class RunEngineTriggerTaskService {
   private readonly engine: RunEngine;
   private readonly tracer: Tracer;
   private readonly traceEventConcern: TraceEventConcern;
+  private readonly metadataMaximumSize: number;
 
   constructor(opts: {
     prisma: PrismaClientOrTransaction;
@@ -57,6 +58,7 @@ export class RunEngineTriggerTaskService {
     runNumberIncrementer: RunNumberIncrementer;
     traceEventConcern: TraceEventConcern;
     tracer: Tracer;
+    metadataMaximumSize: number;
   }) {
     this.prisma = opts.prisma;
     this.engine = opts.engine;
@@ -67,6 +69,7 @@ export class RunEngineTriggerTaskService {
     this.runNumberIncrementer = opts.runNumberIncrementer;
     this.tracer = opts.tracer;
     this.traceEventConcern = opts.traceEventConcern;
+    this.metadataMaximumSize = opts.metadataMaximumSize;
   }
 
   public async call({
@@ -188,7 +191,8 @@ export class RunEngineTriggerTaskService {
       const metadataPacket = body.options?.metadata
         ? handleMetadataPacket(
             body.options?.metadata,
-            body.options?.metadataType ?? "application/json"
+            body.options?.metadataType ?? "application/json",
+            this.metadataMaximumSize
           )
         : undefined;