feat(webapp): show effective default region per environment

RegionsPresenter marks the effective default (env -> project -> global) and
all callers pass the current environment id.

Author: myftija

apps/webapp/app/presenters/v3/RegionsPresenter.server.ts

@@ -3,7 +3,11 @@ import { type Project } from "~/models/project.server";
 import { type User } from "~/models/user.server";
 import { FEATURE_FLAG } from "~/v3/featureFlags";
 import { makeFlag } from "~/v3/featureFlags.server";
-import { defaultVisibilityFilter, resolveComputeAccess } from "~/v3/regionAccess.server";
+import {
+  defaultVisibilityFilter,
+  resolveComputeAccess,
+  resolveEffectiveDefaultWorkerGroupId,
+} from "~/v3/regionAccess.server";
 import { BasePresenter } from "./basePresenter.server";
 import { getCurrentPlan } from "~/services/platform.v3.server";
 
@@ -24,10 +28,12 @@ export class RegionsPresenter extends BasePresenter {
   public async call({
     userId,
     projectSlug,
+    environmentId,
     isAdmin = false,
   }: {
     userId: User["id"];
     projectSlug: Project["slug"];
+    environmentId?: string;
     isAdmin?: boolean;
   }) {
     const project = await this._replica.project.findFirst({
@@ -65,6 +71,20 @@ export class RegionsPresenter extends BasePresenter {
       throw new Error("Default worker instance group not found");
     }
 
+    const environment = environmentId
+      ? await this._replica.runtimeEnvironment.findFirst({
+          select: { defaultWorkerGroupId: true },
+          where: { id: environmentId },
+        })
+      : null;
+
+    // env default -> project default -> global default
+    const effectiveDefaultId = resolveEffectiveDefaultWorkerGroupId({
+      environmentDefaultWorkerGroupId: environment?.defaultWorkerGroupId,
+      projectDefaultWorkerGroupId: project.defaultWorkerGroupId,
+      globalDefaultWorkerGroupId: defaultWorkerInstanceGroupId,
+    });
+
     const hasComputeAccess = await resolveComputeAccess(
       this._replica,
       project.organization.featureFlags
@@ -103,12 +123,14 @@ export class RegionsPresenter extends BasePresenter {
       cloudProvider: region.cloudProvider ?? undefined,
       location: region.location ?? undefined,
       staticIPs: region.staticIPs ?? undefined,
-      isDefault: region.id === defaultWorkerInstanceGroupId,
+      isDefault: region.id === effectiveDefaultId,
       isHidden: region.hidden,
       workloadType: region.workloadType,
     }));
 
-    if (project.defaultWorkerGroupId) {
+    // The effective default may not be in the visible list (e.g. a hidden
+    // region set as the env/project default) — fetch and include it.
+    if (effectiveDefaultId && !regions.some((region) => region.id === effectiveDefaultId)) {
       const defaultWorkerGroup = await this._replica.workerInstanceGroup.findFirst({
         select: {
           id: true,
@@ -121,16 +143,10 @@ export class RegionsPresenter extends BasePresenter {
           hidden: true,
           workloadType: true,
         },
-        where: { id: project.defaultWorkerGroupId },
+        where: { id: effectiveDefaultId },
       });
 
       if (defaultWorkerGroup) {
-        // Unset the default region
-        const defaultRegion = regions.find((region) => region.isDefault);
-        if (defaultRegion) {
-          defaultRegion.isDefault = false;
-        }
-
         regions.push({
           id: defaultWorkerGroup.id,
           name: defaultWorkerGroup.name,

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.playground/route.tsx

@@ -57,6 +57,7 @@ export const loader = async ({ request, params }: LoaderFunctionArgs) => {
     new RegionsPresenter().call({
       userId: user.id,
       projectSlug: projectParam,
+      environmentId: environment.id,
       isAdmin: user.admin || user.isImpersonating,
     }),
   ]);

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test.tasks.$taskParam/route.tsx

@@ -119,6 +119,7 @@ export const loader = async ({ request, params }: LoaderFunctionArgs) => {
       new RegionsPresenter().call({
         userId: user.id,
         projectSlug: projectParam,
+        environmentId: environment.id,
         isAdmin: user.admin || user.isImpersonating,
       }),
     ]);

apps/webapp/app/routes/_app.orgs.$organizationSlug/route.tsx

@@ -106,7 +106,7 @@ export const loader = async ({ request, params }: LoaderFunctionArgs) => {
     }),
     shouldLoadRegions
       ? new RegionsPresenter()
-          .call({ userId: user.id, projectSlug: projectParam! })
+          .call({ userId: user.id, projectSlug: projectParam!, environmentId: environment?.id })
           .then(({ regions }) => regions)
           .catch(() => [] as Region[])
       : Promise.resolve([] as Region[]),

apps/webapp/app/routes/resources.taskruns.$runParam.replay.ts

@@ -201,6 +201,7 @@ export async function loader({ request, params }: LoaderFunctionArgs) {
     new RegionsPresenter().call({
       userId,
       projectSlug: run.project.slug,
+      environmentId: environment.id,
       isAdmin: user.admin || user.isImpersonating,
     }),
   ]);