fix(webapp): reject OTLP events with empty identifiers

Mono-RevId: 93c150de793b922c3be2d58f2f147658d3d0cb8c

Author: carderne

apps/webapp/app/v3/otlpTransform.server.ts

@@ -97,7 +97,7 @@ export function convertLogsToCreateableEvents(
       .map((log) => {
         const logLevel = logLevelToEventLevel(log.severityNumber);
 
-        if (!log.traceId || !log.spanId) {
+        if (!log.traceId?.length || !log.spanId?.length) {
           return;
         }
 
@@ -199,7 +199,7 @@ export function convertSpansToCreateableEvents(
       .map((span) => {
         const isPartial = isPartialSpan(span);
 
-        if (!span.traceId || !span.spanId) {
+        if (!span.traceId?.length || !span.spanId?.length) {
           return;
         }
 

apps/webapp/test/otlpTransform.test.ts

@@ -0,0 +1,71 @@
+import {
+  LogRecord,
+  ResourceLogs,
+  ResourceSpans,
+  SeverityNumber,
+  Span,
+} from "@trigger.dev/otlp-importer";
+import { describe, expect, it } from "vitest";
+import {
+  convertLogsToCreateableEvents,
+  convertSpansToCreateableEvents,
+} from "../app/v3/otlpTransform.server";
+
+const traceId = Buffer.alloc(16, 1);
+const spanId = Buffer.alloc(8, 1);
+
+function resourceLogs(ids: { traceId: Buffer; spanId: Buffer }): ResourceLogs {
+  return ResourceLogs.fromPartial({
+    scopeLogs: [
+      {
+        logRecords: [
+          LogRecord.fromPartial({
+            ...ids,
+            severityNumber: SeverityNumber.INFO,
+            severityText: "INFO",
+            timeUnixNano: 1n,
+          }),
+        ],
+      },
+    ],
+  });
+}
+
+function resourceSpans(ids: { traceId: Buffer; spanId: Buffer }): ResourceSpans {
+  return ResourceSpans.fromPartial({
+    scopeSpans: [
+      {
+        spans: [
+          Span.fromPartial({
+            ...ids,
+            name: "test span",
+            startTimeUnixNano: 1n,
+            endTimeUnixNano: 2n,
+          }),
+        ],
+      },
+    ],
+  });
+}
+
+describe("OTLP event identifier validation", () => {
+  it("drops logs with an empty trace ID", () => {
+    const result = convertLogsToCreateableEvents(
+      resourceLogs({ traceId: Buffer.alloc(0), spanId }),
+      128,
+      "v2"
+    );
+
+    expect(result.events).toEqual([]);
+  });
+
+  it("drops spans with an empty span ID", () => {
+    const result = convertSpansToCreateableEvents(
+      resourceSpans({ traceId, spanId: Buffer.alloc(0) }),
+      128,
+      "v2"
+    );
+
+    expect(result.events).toEqual([]);
+  });
+});