fix(webapp): catalogs live in their own IO-free module

Reading them off the registry dragged the loaders (and so env.server and
the engine singleton) into the pure renderer and its unit test. The
catalogs-by-value map now imports only the per-report messages files.

Author: kathiekiwi

apps/webapp/app/presenters/v3/reports/report-message-catalogs.ts

@@ -0,0 +1,11 @@
+/**
+ * Catalogs by value, in a module that imports ONLY the per-report `*-messages`
+ * files — no loaders, no IO. Presentation stays decoupled from the data layer,
+ * and a value import can't be tree-shaken away.
+ */
+import { healthMessages } from "./health/health-messages";
+import { type ReportMessages } from "./report-messages";
+
+export const REPORT_MESSAGE_CATALOGS: Record<string, ReportMessages> = {
+  health: healthMessages,
+};

apps/webapp/app/presenters/v3/reports/report-messages.ts

@@ -5,7 +5,7 @@
  * No report vocabulary here — that would re-couple the renderer to a specific report.
  */
 
-import { REPORT_REGISTRY } from "./report-registry";
+import { REPORT_MESSAGE_CATALOGS } from "./report-message-catalogs";
 import { type ReasonCode, type Severity } from "./report-view-model";
 
 /**
@@ -23,14 +23,11 @@ export type ReportMessages = {
   actionMessage(code: ReasonCode): string;
 };
 
-/**
- * Look up a report's catalog by `vm.title`. Catalogs live as values on the
- * report registry entries — there is deliberately no register-at-import-time
- * step: a side-effect registration is exactly what the production bundle
- * tree-shakes away under `"sideEffects": false`.
- */
+/** Look up a report's catalog by `vm.title`. Catalogs are values, never
+ * registered at import time — side-effect registration is what the production
+ * bundle tree-shakes away. */
 export function reportMessages(title: string): ReportMessages {
-  const messages = REPORT_REGISTRY[title]?.messages;
+  const messages = REPORT_MESSAGE_CATALOGS[title];
   if (!messages) {
     throw new Error(`report-messages: no catalog registered for report "${title}"`);
   }

apps/webapp/app/presenters/v3/reports/report-registry.ts

@@ -10,21 +10,11 @@
 import { type AuthenticatedEnvironment } from "~/services/apiAuth.server";
 import { interpret as interpretHealth } from "./health/health";
 import { loadHealthInput } from "./health/health-data";
-import { healthMessages } from "./health/health-messages";
-import { type ReportMessages } from "./report-messages";
 import { type ReportViewModel } from "./report-view-model";
 
 export type ReportLoader<TInput> = {
   load: (env: AuthenticatedEnvironment, period: string) => Promise<TInput>;
   interpret: (input: TInput) => ReportViewModel;
-  /**
-   * The report's message catalog, carried BY VALUE on the registry entry. It
-   * used to be registered as a side effect of importing the catalog module —
-   * which the production SSR bundle tree-shook away (`"sideEffects": false`),
-   * leaving `GET /api/v1/reports/health` throwing "no catalog registered".
-   * A value on the entry cannot be dropped.
-   */
-  messages: ReportMessages;
 };
 
 function defineReport<TInput>(loader: ReportLoader<TInput>): ReportLoader<unknown> {
@@ -35,7 +25,6 @@ export const REPORT_REGISTRY: Record<string, ReportLoader<unknown>> = {
   health: defineReport({
     load: (env, period) => loadHealthInput(env, period),
     interpret: interpretHealth,
-    messages: healthMessages,
   }),
 };