From bb77ee1abf9fb81f58ce27ed49f5e70811f12ceb Mon Sep 17 00:00:00 2001 From: Matt Aitken Date: Thu, 16 Apr 2026 18:10:32 +0100 Subject: [PATCH] Error page graph: for a time bucket don't fill zeros for a version with no errors This caused performance issues with large numbers of versions, and bad UX when hovering the graph (showing irrelevant versions) --- .../webapp/app/presenters/v3/ErrorGroupPresenter.server.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/apps/webapp/app/presenters/v3/ErrorGroupPresenter.server.ts b/apps/webapp/app/presenters/v3/ErrorGroupPresenter.server.ts index 5e9df362e4..d2f6bbfcbe 100644 --- a/apps/webapp/app/presenters/v3/ErrorGroupPresenter.server.ts +++ b/apps/webapp/app/presenters/v3/ErrorGroupPresenter.server.ts @@ -242,10 +242,15 @@ export class ErrorGroupPresenter extends BasePresenter { const sortedVersions = sortVersionsDescending([...versionSet]); + // Build the data for the graph + // For each time bucket, if a value exists for a version set the value (don't add zeros) const data = buckets.map((epoch) => { const point: Record = { date: new Date(epoch * 1000) }; for (const version of sortedVersions) { - point[version] = byBucketVersion.get(`${epoch}:${version}`) ?? 0; + const versionValue = byBucketVersion.get(`${epoch}:${version}`); + if (versionValue) { + point[version] = versionValue; + } } return point; });