From 482f54988653423cd4150d60bb8aed2eade24ffd Mon Sep 17 00:00:00 2001 From: jrtxio Date: Fri, 16 Oct 2026 19:18:32 +0800 Subject: [PATCH] Pass the update-payload keyword only when payloads are configured The release smoke on CI hit a stale compiled release.rkt that did not accept the new keyword: files committed in the same second can slip past raco make's mtime freshness check. Calling the old signature for the default flow keeps mixed-version compilations working. --- rivet-cli/main.rkt | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/rivet-cli/main.rkt b/rivet-cli/main.rkt index 30f0cc7..ba07b45 100644 --- a/rivet-cli/main.rkt +++ b/rivet-cli/main.rkt @@ -182,11 +182,18 @@ [(list* "--update-payload" spec tail) (loop tail (cons spec payloads))] [(cons _ tail) (loop tail payloads)]))) + ;; Passing #:update-payloads only when payloads exist keeps a stale + ;; compiled release.rkt (same-second mtime can fool raco make's + ;; freshness check) working for the default release flow. (define-values (installer manifest sbom notices portable-zip) - (release-project! (current-project!) - #:production? production? - #:updates? updates? - #:update-payloads update-payloads)) + (if (null? update-payloads) + (release-project! (current-project!) + #:production? production? + #:updates? updates?) + (release-project! (current-project!) + #:production? production? + #:updates? updates? + #:update-payloads update-payloads))) (say "release installer: ~a" installer) (say "portable zip: ~a" portable-zip) (when (eq? (system-type 'os) 'unix)