add converter for space-within-parens rule (#193)

* add converter for space-within-parens rule

* convert rule to eslint equivalent

* fix eslint error

* add notices for space-within-parens

* add notice only if parameter supplied

* fix duplicates from conflict

* make sure converter is actually used

Author: bmeverett

src/rules/converters.ts

@@ -107,6 +107,7 @@ import { convertRadix } from "./converters/radix";
 import { convertRestrictPlusOperands } from "./converters/restrict-plus-operands";
 import { convertSemicolon } from "./converters/semicolon";
 import { convertSpaceBeforeFunctionParen } from "./converters/space-before-function-paren";
+import { convertSpaceWithinParens } from "./converters/space-within-parens";
 import { convertSwitchDefault } from "./converters/switch-default";
 import { convertTypedefWhitespace } from "./converters/typedef-whitespace";
 import { convertTypeLiteralDelimiter } from "./converters/type-literal-delimiter";
@@ -233,6 +234,7 @@ export const converters = new Map([
     ["restrict-plus-operands", convertRestrictPlusOperands],
     ["semicolon", convertSemicolon],
     ["space-before-function-paren", convertSpaceBeforeFunctionParen],
+    ["space-within-parens", convertSpaceWithinParens],
     ["switch-default", convertSwitchDefault],
     ["triple-equals", convertTripleEquals],
     ["type-literal-delimiter", convertTypeLiteralDelimiter],
@@ -254,7 +256,9 @@ export const converters = new Map([
     // ["import-blacklist", convertImportBlacklist], // no-restricted-imports
     // ["no-duplicate-variable", convertNoDuplicateVariable], // no-redeclare
     // ["no-unused-expression", convertNoUnusedExpression], // no-unused-expressions
-    // ["space-within-parens", convertSpaceWithinParens], // space-in-parens
+    // ["no-void-expression", convertNoVoidExpression], // (no exact equivalent)
+    // ["quotemark", convertQuotemark], // quotes
+    // ["triple-equals", convertTripleEquals], // eqeqeq
     // ["variable-name", convertVariableName], // a bunch of rules...
 
     // tslint-microsoft-contrib rules:

src/rules/converters/space-within-parens.ts

@@ -0,0 +1,21 @@
+import { RuleConverter } from "../converter";
+
+export const convertSpaceWithinParens: RuleConverter = tslintRule => {
+    let arg = "never";
+    const notices = [];
+
+    if (tslintRule.ruleArguments.length === 1) {
+        arg = "always";
+        notices.push("The number of spaces will be ignored");
+    }
+
+    return {
+        rules: [
+            {
+                ruleArguments: [arg],
+                ruleName: "@typescript-eslint/space-within-parens",
+                notices,
+            },
+        ],
+    };
+};

src/rules/converters/tests/space-within-parens.test.ts

@@ -0,0 +1,35 @@
+import { convertSpaceWithinParens } from "../space-within-parens";
+
+describe(convertSpaceWithinParens, () => {
+    test("conversion without arguments", () => {
+        const result = convertSpaceWithinParens({
+            ruleArguments: [],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleArguments: ["never"],
+                    ruleName: "@typescript-eslint/space-within-parens",
+                    notices: [],
+                },
+            ],
+        });
+    });
+
+    test("conversion with min spaces arguement", () => {
+        const result = convertSpaceWithinParens({
+            ruleArguments: [5],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleArguments: ["always"],
+                    ruleName: "@typescript-eslint/space-within-parens",
+                    notices: ["The number of spaces will be ignored"],
+                },
+            ],
+        });
+    });
+});