Skip to content

Function does not support crossplane v2 #63

@jwitko

Description

@jwitko

Attempting to use this function in crossplane v2 results in:

        selected CompositionRevision
        <REDACTED> does not have a valid
        function pipeline: function "function-cidr" (active revision
        "function-cidr-ef7de3493998") is missing required capabilities:
        composition

Can we please bring this function up to date so it can be used with the latest versions of crossplane?

It looks like there is already a PR up which would bring the function-go-sdk up to date
#40

I believe what needs to happen is:

  1. go.mod: Bump github.com/crossplane/function-sdk-go to v0.6.0

  2. fn.go: Change the embedded struct from fnv1beta1.UnimplementedFunctionRunnerServiceServer to v1.UnimplementedFunctionRunnerServiceServer, and update the RunFunction signature to use v1 proto types instead of v1beta1

  3. main.go: The Serve() function now takes v1.FunctionRunnerServiceServer and automatically wraps it for v1beta1 backward compatibility, so I think we need to update this as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions