cleanup bug : createReexecCmd: dead if logLevel != "" guard around _LIBCONTAINER_LOGLEVEL

[shivansh-source]

In createReexecCmd (cmd/urunc/create.go), the log level env var is gated on a condition that can never be false:

logLevel := strconv.Itoa(int(logrus.GetLevel()))
if logLevel != "" {
    reexecCommand.Env = append(reexecCommand.Env, "_LIBCONTAINER_LOGLEVEL="+logLevel)
}

strconv.Itoa always returns a non-empty string . so logLevel != "" is always true and the guard is dead code

not a functionality bug only a cleanup issue .

[ananos]

Thanks @shivansh-source, the observation is correct -- strconv.Itoa never returns an empty string, so the guard is always true. This is a leftover from the runc code this block was adapted from, where the log level is a plain string that can genuinely be empty.

It is harmless dead code though, and a 2-line deletion does not really warrant a standalone issue and PR cycle. We will fold it into the next cleanup pass over cmd/, together with similar vestiges. Flagging it as Low prio -- thanks for spotting it.