From 61169d85b97461e8b0fa25d25e65d44c59a95b9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20S=C3=A1nchez?= Date: Tue, 8 Sep 2026 13:17:43 -0600 Subject: [PATCH 1/2] fix[backend](changeset): allow empty alert/incident notification email lists --- ..._allow_empty_alert_notification_emails.xml | 19 +++++++++++++++++++ .../resources/config/liquibase/master.xml | 4 +++- 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 backend/src/main/resources/config/liquibase/changelog/20260908001_allow_empty_alert_notification_emails.xml diff --git a/backend/src/main/resources/config/liquibase/changelog/20260908001_allow_empty_alert_notification_emails.xml b/backend/src/main/resources/config/liquibase/changelog/20260908001_allow_empty_alert_notification_emails.xml new file mode 100644 index 000000000..e7dd38ac5 --- /dev/null +++ b/backend/src/main/resources/config/liquibase/changelog/20260908001_allow_empty_alert_notification_emails.xml @@ -0,0 +1,19 @@ + + + + + + + + + diff --git a/backend/src/main/resources/config/liquibase/master.xml b/backend/src/main/resources/config/liquibase/master.xml index 506b2b9f4..74225677e 100644 --- a/backend/src/main/resources/config/liquibase/master.xml +++ b/backend/src/main/resources/config/liquibase/master.xml @@ -604,5 +604,7 @@ - + + + From 3cbac85c83492dd3e7b2735d73c4eaa27a412805 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20S=C3=A1nchez?= Date: Tue, 8 Sep 2026 13:20:47 -0600 Subject: [PATCH 2/2] fix[frontend](alerts): stop nagging when notification email fields are empty --- .../alert-management/alert-view/alert-view.component.ts | 3 --- .../incident-management/incident-management.component.ts | 5 +---- .../app-config-sections/app-config-sections.component.html | 2 +- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/frontend/src/app/data-management/alert-management/alert-view/alert-view.component.ts b/frontend/src/app/data-management/alert-management/alert-view/alert-view.component.ts index 7f7a188f6..88ca73d8b 100644 --- a/frontend/src/app/data-management/alert-management/alert-view/alert-view.component.ts +++ b/frontend/src/app/data-management/alert-management/alert-view/alert-view.component.ts @@ -38,7 +38,6 @@ import {SortEvent} from '../../../shared/directives/sortable/type/sort-event'; import {ElasticOperatorsEnum} from '../../../shared/enums/elastic-operators.enum'; import {DataNatureTypeEnum} from '../../../shared/enums/nature-data.enum'; import {ElasticDataService} from '../../../shared/services/elasticsearch/elastic-data.service'; -import {CheckEmailConfigService, ParamShortType} from '../../../shared/services/util/check-email-config.service'; import {AlertTags} from '../../../shared/types/alert/alert-tag.type'; import {UtmAlertType} from '../../../shared/types/alert/utm-alert.type'; import {ElasticFilterType} from '../../../shared/types/filter/elastic-filter.type'; @@ -79,7 +78,6 @@ export class AlertViewComponent implements OnInit, OnDestroy { private alertDataTypeBehavior: AlertDataTypeBehavior, private alertTagService: AlertTagService, private spinner: NgxSpinnerService, - private checkEmailConfigService: CheckEmailConfigService, private localStorage: LocalStorageService, private alertActionRefreshService: AlertActionRefreshService) { // this.tableWidth = this.pageWidth - 300; @@ -150,7 +148,6 @@ export class AlertViewComponent implements OnInit, OnDestroy { ngOnInit() { this.openAlerts = this.localStorage.retrieve(OPEN_ALERTS_KEY); - this.checkEmailConfigService.check(ParamShortType.Alert); this.setInitialWidth(); this.getTags(); this.activatedRoute.queryParams.subscribe(params => { diff --git a/frontend/src/app/incident/incident-management/incident-management.component.ts b/frontend/src/app/incident/incident-management/incident-management.component.ts index 39d9f13e6..c040cbe5b 100644 --- a/frontend/src/app/incident/incident-management/incident-management.component.ts +++ b/frontend/src/app/incident/incident-management/incident-management.component.ts @@ -15,7 +15,6 @@ import {IncidentFilterType} from '../../shared/types/incident/incident-filter.ty import {UtmIncidentType} from '../../shared/types/incident/utm-incident.type'; import {TimeFilterType} from '../../shared/types/time-filter.type'; import {calcTableDimension} from '../../shared/util/screen.util'; -import {CheckEmailConfigService, ParamShortType} from "../../shared/services/util/check-email-config.service"; @Component({ selector: 'app-incident-management', @@ -60,13 +59,11 @@ export class IncidentManagementComponent implements OnInit, OnDestroy { constructor(private utmIncidentService: UtmIncidentService, private modalService: NgbModal, - private activatedRoute: ActivatedRoute, - private checkEmailConfigService: CheckEmailConfigService) { + private activatedRoute: ActivatedRoute) { } ngOnInit() { - this.checkEmailConfigService.check(ParamShortType.Incident); this.setInitialWidth(); this.getIncidents(); this.activatedRoute.queryParams.subscribe(params => { diff --git a/frontend/src/app/shared/components/utm/config/app-config-sections/app-config-sections.component.html b/frontend/src/app/shared/components/utm/config/app-config-sections/app-config-sections.component.html index bc3288290..1d0edd07a 100644 --- a/frontend/src/app/shared/components/utm/config/app-config-sections/app-config-sections.component.html +++ b/frontend/src/app/shared/components/utm/config/app-config-sections/app-config-sections.component.html @@ -109,7 +109,7 @@
{{section.section | titlecase}}
[required]="conf.confParamRequired" class="form-control" rows="4"> - + Please enter valid email addresses separated by commas.