Skip to content

[codex] fix Trae SOLO message sending#2

Open
Winn1y wants to merge 1 commit into
vilmire:mainfrom
Winn1y:codex-fix-trae-solo-send
Open

[codex] fix Trae SOLO message sending#2
Winn1y wants to merge 1 commit into
vilmire:mainfrom
Winn1y:codex-fix-trae-solo-send

Conversation

@Winn1y
Copy link
Copy Markdown

@Winn1y Winn1y commented May 23, 2026

Summary

  • 修复 Trae SOLO 模式下消息已发送后,daemon 自动确认误点终止/取消类按钮的问题。
  • 自动确认现在会跳过 Stop/Cancel/Terminate 等破坏性按钮,并优先选择安全按钮。
  • 补充 approval-utils 覆盖 destructive button 的单测。

Root Cause

Trae SOLO 发送后会进入生成态并显示终止类操作;原先自动确认逻辑在没有匹配到正向按钮时会回退点击第一个按钮,导致消息明明已发出却被自动终止。

Validation

  • node adhdev-providers\tests\trae-send-message.test.js
  • node adhdev-providers\validate.js adhdev-providers\ide\trae\provider.json
  • npm.cmd run test -w packages/daemon-core -- approval-utils.test.ts
  • npm.cmd run typecheck -w packages/daemon-core

@github-actions
Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@Winn1y Winn1y marked this pull request as ready for review May 23, 2026 12:08
Copy link
Copy Markdown
Owner

@vilmire vilmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM. I reviewed the diff and validated locally with:

  • npm run test -w packages/daemon-core -- approval-utils.test.ts
  • npm run typecheck -w packages/daemon-core
  • npm run test -w packages/daemon-core
  • npm run build -w packages/daemon-core

The PR correctly avoids auto-approving destructive Stop/Cancel/Terminate-style buttons and covers the unsafe-button behavior in tests.

Merge is still blocked by the failing CLA check. Please sign the CLA by commenting exactly:

I have read the CLA Document and I hereby sign the CLA

Once the CLA check passes, this should be safe to merge.

@Winn1y
Copy link
Copy Markdown
Author

Winn1y commented May 24, 2026

Do I need to do anything? @vilmire

@Winn1y Winn1y force-pushed the codex-fix-trae-solo-send branch from d32eb0e to 2bb6540 Compare May 24, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants