[codex] fix Trae SOLO message sending#2
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
vilmire
left a comment
There was a problem hiding this comment.
Code-wise LGTM. I reviewed the diff and validated locally with:
- npm run test -w packages/daemon-core -- approval-utils.test.ts
- npm run typecheck -w packages/daemon-core
- npm run test -w packages/daemon-core
- npm run build -w packages/daemon-core
The PR correctly avoids auto-approving destructive Stop/Cancel/Terminate-style buttons and covers the unsafe-button behavior in tests.
Merge is still blocked by the failing CLA check. Please sign the CLA by commenting exactly:
I have read the CLA Document and I hereby sign the CLA
Once the CLA check passes, this should be safe to merge.
|
Do I need to do anything? @vilmire |
d32eb0e to
2bb6540
Compare
Summary
Root Cause
Trae SOLO 发送后会进入生成态并显示终止类操作;原先自动确认逻辑在没有匹配到正向按钮时会回退点击第一个按钮,导致消息明明已发出却被自动终止。
Validation