fix(cli): restore build progress rendering

Author: GaspardKirira

include/vix/cli/util/NetworkProgress.hpp

@@ -6198,7 +6198,8 @@ namespace vix::commands::BuildCommand
 
           const bool legacyBuildQuiet =
               opt_.quiet ||
-              !showRawBuildOutput;
+              (liveBuild &&
+               !showRawBuildOutput);
 
           const process::ExecResult r =
               measurePhase(

src/commands/BuildCommand.cpp

@@ -27,7 +27,6 @@
 #include <vix/utils/Env.hpp>
 #include <vix/cli/util/Semver.hpp>
 #include <vix/cli/util/GitProgress.hpp>
-#include <vix/cli/util/NetworkProgress.hpp>
 #include <vix/cli/util/ProjectMutation.hpp>
 
 #include <nlohmann/json.hpp>
@@ -464,11 +463,24 @@ namespace vix::commands
         std::vector<std::string> args,
         const fs::path &cwd);
 
+    static bool install_progress_is_tty()
+    {
+#ifdef _WIN32
+      if (_isatty(_fileno(stdout)) == 0)
+        return false;
+#else
+      if (::isatty(STDOUT_FILENO) == 0)
+        return false;
+#endif
+      const char *term = std::getenv("TERM");
+      return (!term || std::string_view(term) != "dumb") && std::getenv("NO_COLOR") == nullptr;
+    }
+
     class GitInstallProgress
     {
     public:
       GitInstallProgress(std::string dependency, std::size_t packageIndex, std::size_t packageCount)
-          : dependency_(std::move(dependency)), packageIndex_(packageIndex), packageCount_(packageCount), parser_([this](const auto &event)
+          : dependency_(std::move(dependency)), packageIndex_(packageIndex), packageCount_(packageCount), started_(std::chrono::steady_clock::now()), tty_(install_progress_is_tty()), parser_([this](const auto &event)
                                                                                                                                                                                                { render(event); }) {}
 
       void push(std::string_view chunk) { parser_.push(chunk); }
@@ -484,30 +496,50 @@ namespace vix::commands
       void finish()
       {
         parser_.finish();
-        progress_.stop();
+        if (visible_)
+        {
+          std::cout << "\r\033[2K" << std::flush;
+          visible_ = false;
+        }
       }
 
     private:
       void render(const vix::cli::util::GitProgressEvent &event)
       {
+        // CI output must remain useful without terminal control sequences.
+        const auto now = std::chrono::steady_clock::now();
+        // The first measurable Git event is deliberately not delayed.  The
+        // old delay made a real remote operation look hung.
+        if (visible_ && event.phase == lastPhase_ && now - lastRender_ < std::chrono::milliseconds(100))
+          return;
         std::ostringstream line;
-        line << event.phase;
+        line << "  " << CYAN << "•" << RESET << " " << CYAN << BOLD << dependency_ << RESET;
         if (packageCount_ > 1)
-          line << " " << dependency_ << " (" << (packageIndex_ + 1) << "/" << packageCount_ << " packages)";
-        else
-          line << " " << dependency_;
+          line << " " << GRAY << "(" << (packageIndex_ + 1) << "/" << packageCount_ << " packages)" << RESET;
+        line << "  " << GRAY << event.phase;
         if (event.percent)
           line << " " << *event.percent << "%";
         if (!event.transferred.empty())
           line << "  " << event.transferred;
         if (!event.speed.empty())
           line << "  " << event.speed;
-        progress_.update(line.str());
+        line << RESET;
+        if (tty_)
+          std::cout << "\r\033[2K" << line.str() << std::flush;
+        else
+          std::cout << dependency_ << ": " << event.phase
+                    << (event.percent ? std::string(" ") + std::to_string(*event.percent) + "%" : "") << "\n"
+                    << std::flush;
+        visible_ = true;
+        lastRender_ = now;
+        lastPhase_ = event.phase;
       }
       std::string dependency_;
       std::size_t packageIndex_{};
       std::size_t packageCount_{};
-      vix::cli::util::NetworkProgress progress_{dependency_};
+      std::chrono::steady_clock::time_point started_, lastRender_{};
+      bool tty_{false}, visible_{false};
+      std::string lastPhase_;
       vix::cli::util::GitProgressParser parser_;
     };
 

src/commands/InstallCommand.cpp

@@ -13,7 +13,6 @@
  */
 #include <vix/cli/commands/RegistryCommand.hpp>
 #include <vix/cli/util/Shell.hpp>
-#include <vix/cli/util/NetworkProgress.hpp>
 #include <vix/cli/util/Ui.hpp>
 #include <vix/cli/Style.hpp>
 #include <vix/utils/Env.hpp>
@@ -82,12 +81,9 @@ namespace vix::commands
       return name;
     }
 
-    static int normalize_registry_worktree(const fs::path &dir, bool quiet,
-                                           vix::cli::util::NetworkProgress *progress = nullptr)
+    static int normalize_registry_worktree(const fs::path &dir, bool quiet)
     {
-      if (progress)
-        progress->phase("Fetching registry index");
-      else if (!quiet)
+      if (!quiet)
         step("fetching origin (prune)...");
       {
         const std::string cmd =
@@ -97,9 +93,7 @@ namespace vix::commands
           return rc;
       }
 
-      if (progress)
-        progress->phase("Preparing registry index");
-      else if (!quiet)
+      if (!quiet)
         step("checking out main...");
       {
         const std::string cmd =
@@ -109,7 +103,7 @@ namespace vix::commands
           return rc;
       }
 
-      if (!quiet && !progress)
+      if (!quiet)
         step("resetting to origin/main...");
       {
         const std::string cmd =
@@ -191,50 +185,43 @@ namespace vix::commands
           vix::cli::util::warn_line(std::cerr, "Tip: re-run with VIX_DEBUG=1 to see git output");
       };
 
-      vix::cli::util::NetworkProgress progress("registry");
-
       if (!fs::exists(dir))
       {
         if (!quiet)
-          progress.phase("Connecting to registry");
+          step("cloning index (depth=1)...");
         const std::string cmd =
             "git clone -q --depth 1 " + registry_repo_url() + " " + dir.string();
 
         const int rc = git_run(cmd);
         if (rc != 0)
         {
-          progress.failure();
           print_sync_failure();
           return rc;
         }
 
-        const int nrc = normalize_registry_worktree(
-            dir, quiet, quiet ? nullptr : &progress);
+        const int nrc = normalize_registry_worktree(dir, quiet);
         if (nrc != 0)
         {
-          progress.failure();
           print_sync_failure();
           return nrc;
         }
 
         if (!quiet)
-          progress.success("Registry synced: " + dir.string());
+          vix::cli::util::ok_line(std::cout, "registry synced: " + dir.string());
         return 0;
       }
 
       if (!quiet)
-        progress.phase("Fetching registry index");
-      const int nrc = normalize_registry_worktree(
-          dir, quiet, quiet ? nullptr : &progress);
+        step("normalizing worktree...");
+      const int nrc = normalize_registry_worktree(dir, quiet);
       if (nrc != 0)
       {
-        progress.failure();
         print_sync_failure();
         return nrc;
       }
 
       if (!quiet)
-        progress.success("Registry synced: " + dir.string());
+        vix::cli::util::ok_line(std::cout, "registry synced: " + dir.string());
       return 0;
     }
   } // namespace