-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Context
PR #179 revealed that SDK integration tests weren't catching CLI changes that broke SDK compatibility. We've added a test-sdk-e2e CI job that always runs E2E tests for:
- β
Core JS Client (
vizzlyScreenshot) - β
Vitest SDK (
toMatchScreenshotmatcher) - β
Ember SDK (
vizzlyScreenshothelper) - β
Ruby SDK (
Vizzly.screenshot)
However, two SDKs still only have unit tests with mocked server responses:
- β Storybook SDK
- β Static-site SDK
What's needed
Storybook SDK E2E
Create a minimal test Storybook project that the SDK can crawl and capture screenshots from:
- Add
clients/storybook/test-storybook/with a simple Storybook setup (2-3 stories) - Add
npm run test:e2escript that runs the Storybook SDK against it - Add to
test-sdk-e2eCI job
Static-site SDK E2E
Create a minimal test site that the SDK can crawl:
- Add
clients/static-site/test-site/with a few HTML pages - Add
npm run test:e2escript that runs the static-site SDK against it - Add to
test-sdk-e2eCI job
Why this matters
These E2E tests ensure that changes to the CLI's TDD handler response format (like the status field changes in #169) are caught before they break SDK users.
Metadata
Metadata
Assignees
Labels
No labels