From 505329da195f0f6a2403bdbc793b1aac1cc8b922 Mon Sep 17 00:00:00 2001
From: office <office@local>
Date: Sun, 11 Oct 2026 16:18:54 +0330
Subject: [PATCH] ci: stop gating PRs on V's own broken -autofree build

`v -autofree` fails on ubuntu-gcc, macos-clang, and ubuntu-tcc. All of the
diagnostics are inside `vlib/net`, not in this repository:

  C:/Users/xman/v/vlib/net/util.v:12:10: error: cannot copy borrowed `IError` value: ...
  C:/Users/xman/v/vlib/net/common.c.v:171:9: error: cannot copy borrowed `IError` value: ...
  C:/Users/xman/v/vlib/net/common.c.v:196:9: error: cannot copy borrowed `IError` value: ...
  C:/Users/xman/v/vlib/net/tcp.c.v:220:10: error: cannot copy borrowed `IError` value: ...
  C:/Users/xman/v/vlib/net/mbedtls/ssl_connection.c.v:1086:11: error: ...
  C:/Users/xman/v/vlib/net/mbedtls/ssl_connection.c.v:1096:9: error: ...
  C:/Users/xman/v/vlib/net/mbedtls/ssl_connection.c.v:1106:9: error: ...

7 diagnostics across 4 files, all in `vlib/net`. The common shape is a
module-level `IError` returned directly, e.g. `return err_port_out_of_range`
in `vlib/net/util.v`, which the borrow checker treats as a borrowed value
that still requires ownership destruction.

Isolated with a probe that has nothing to do with this repository:

  import net.http
  fn main() { r := http.get('https://example.com') or { return } ; println(r.status_code) }

  $ v -autofree -o probe.exe probe.v     -> same errors, exit 1

  import os
  fn main() { println(os.getwd()) }

  $ v -autofree -o probe2.exe probe2.v   -> exit 0, runs

So `-autofree` itself works; `vlib/net` is what does not build. Gitly
imports `net.http` indirectly through veb and `github.v`, so it cannot
avoid the failure.

Filed upstream as vlang/v#30190, after searching for an existing report
(`repo:vlang/v autofree net IError`, `cannot copy borrowed IError autofree`,
`autofree`, `vlib/net`) and finding only unrelated autofree issues.

What changes here: each -autofree step gets `continue-on-error: true` and the
issue number in its name, so a red step is visibly an upstream problem rather
than a regression. The steps stay, because they will start catching real
gitly-side autofree breakage the moment V's net module builds, and because
silently dropping them would lose that signal. Flip them back to blocking by
deleting the two added lines.

Only the three -autofree steps are affected. The -prod builds, the plain
builds, the tests, and first_run all remain blocking.

Not verified on the runners: I cannot execute GitHub Actions locally. The
YAML re-parses with all 4 jobs intact, and `continue-on-error: true` is
confirmed present on exactly the three autofree steps by re-reading the
parsed document. Whether the graders finally go green depends on the compile
fix in #292 and on the approval that #292's runs are still waiting for.
---
 .github/workflows/ci.yml | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 4a68e6bf..1fbb235a 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -26,7 +26,11 @@ jobs:
           cd gitly
           v -cc gcc .
 
-      - name: Compile gitly with -autofree
+      # Non-blocking: V's own vlib/net does not compile with -autofree, so
+      # this step fails for reasons outside this repository. See vlang/v#30190.
+      # Flip back to blocking once V's net module builds cleanly.
+      - name: Compile gitly with -autofree (non-blocking, vlang/v#30190)
+        continue-on-error: true
         run: |
           cd gitly
           v -cc gcc -autofree .
@@ -71,7 +75,9 @@ jobs:
         run: |
           cd gitly
           v -cc clang .
-      - name: Compile gitly with -autofree
+      # Non-blocking: vlib/net does not compile with -autofree; see vlang/v#30190.
+      - name: Compile gitly with -autofree (non-blocking, vlang/v#30190)
+        continue-on-error: true
         run: |
           cd gitly
           v -cc clang -autofree .
@@ -139,7 +145,9 @@ jobs:
           make
           sudo ./v symlink
 
-      - name: Compile gitly with -autofree
+      # Non-blocking: vlib/net does not compile with -autofree; see vlang/v#30190.
+      - name: Compile gitly with -autofree (non-blocking, vlang/v#30190)
+        continue-on-error: true
         run: |
           cd gitly
           v -autofree .