Skip to content

Commit 98052a3

Browse files
authored
chore: integrate pm version to UI (#25)
Make sure to pass the `versions` data to the generated json result so that the UI can properly render version numbers.
1 parent 2611ddc commit 98052a3

File tree

5 files changed

+30
-28
lines changed

5 files changed

+30
-28
lines changed

.github/workflows/benchmark.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,6 @@ jobs:
201201
}
202202
203203
console.log('Benchmark cleaning completed');
204-
- name: Copy Versions File
205-
run: |
206-
# Find any versions.json file from the downloaded versions artifacts and copy it to results
207-
find versions-temp -name "versions.json" -type f | head -1 | xargs -I {} cp {} ./results/versions.json || echo "No versions.json found"
208204
- name: Process Results
209205
run: |
210206
bash ./scripts/process-results.sh

app/src/components/leaderboard.tsx

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@ interface LeaderboardProps {
99
chartData: BenchmarkChartData;
1010
}
1111

12-
13-
14-
15-
1612
export const Leaderboard = ({ chartData }: LeaderboardProps) => {
1713
const { enabledPackageManagers } = usePackageManagerFilter();
1814
const { theme } = useTheme();
@@ -39,10 +35,6 @@ export const Leaderboard = ({ chartData }: LeaderboardProps) => {
3935
</p>
4036
</div>
4137
</div>
42-
<div className="flex items-center gap-1 text-xs text-muted-foreground">
43-
<div className="w-2 h-2 rounded-full bg-yellow-500" />
44-
<span>wins</span>
45-
</div>
4638
</div>
4739

4840
{/* Flexible grid layout for tools */}
@@ -81,13 +73,6 @@ export const Leaderboard = ({ chartData }: LeaderboardProps) => {
8173
/>
8274
</div>
8375
)}
84-
85-
{/* Superscript-style win indicator */}
86-
{item.wins > 0 && (
87-
<div className="absolute -top-1 -right-1 bg-yellow-500 text-white rounded-full px-1.5 py-0.5 text-[10px] font-medium">
88-
{item.wins}
89-
</div>
90-
)}
9176
</div>
9277
);
9378
})}

app/src/hooks/use-chart-data.ts

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,10 @@ export const useChartData = (): UseChartDataReturn => {
3737

3838
// Fetch versions data (optional)
3939
let versions: PackageManagerVersions | undefined;
40-
try {
41-
const versionsResponse = await fetch(`/latest/versions.json`);
42-
if (versionsResponse.ok) {
43-
versions = await versionsResponse.json() as PackageManagerVersions;
44-
} else {
45-
console.warn("Versions data not available");
46-
}
47-
} catch (versionsError) {
48-
console.warn("Failed to fetch versions data:", versionsError);
40+
if (chartData.versions) {
41+
versions = chartData.versions;
42+
} else {
43+
console.warn("Versions data not available");
4944
}
5045

5146
// Combine chart data with versions

scripts/generate-chart.js

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,31 @@ function generateChartData(option = {}) {
151151
};
152152
}
153153

154+
// Load package manager version data
155+
function loadPackageManagersVersionData() {
156+
const versionsFile = path.resolve(RESULTS_DIR, "versions.json");
157+
158+
try {
159+
if (!fs.existsSync(versionsFile)) {
160+
console.warn(`Warning: Versions file ${versionsFile} does not exist`);
161+
return {};
162+
}
163+
164+
const data = JSON.parse(fs.readFileSync(versionsFile, "utf8"));
165+
return data || {};
166+
} catch (error) {
167+
console.warn(
168+
`Warning: Could not read versions from ${versionsFile}:`,
169+
error.message,
170+
);
171+
return {};
172+
}
173+
}
174+
154175
const dumpChartData = () => {
155176
const chartData = generateChartData();
156177
const perPackageCountChartData = generateChartData({ perPackageCount: true });
178+
const versions = loadPackageManagersVersionData()
157179

158180
const results = {
159181
chartData: {
@@ -168,6 +190,7 @@ const dumpChartData = () => {
168190
packageManagers: perPackageCountChartData.packageManagers,
169191
colors: perPackageCountChartData.colors,
170192
},
193+
versions,
171194
};
172195

173196
fs.writeFileSync(

scripts/process-results.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ DATE=$(date +%Y-%m-%d)
88
mkdir -p "results/$DATE"
99
mkdir -p "results/latest"
1010

11+
# Find any versions.json file from the downloaded versions artifacts and copy it to results
12+
find versions-temp -name "versions.json" -type f | head -1 | xargs -I {} cp {} ./results/$DATE/versions.json || echo "No versions.json found"
13+
1114
# Function to print summary of results
1215
print_summary() {
1316
local file=$1

0 commit comments

Comments
 (0)