diff --git a/packages/cli/binding/src/check/mod.rs b/packages/cli/binding/src/check/mod.rs index 722a52578c..6e05fbf5c4 100644 --- a/packages/cli/binding/src/check/mod.rs +++ b/packages/cli/binding/src/check/mod.rs @@ -178,7 +178,6 @@ pub(crate) async fn execute_check( Some(Err(failure)) => { if failure.errors == 0 && failure.warnings > 0 { output::warn(lint_message_kind.warning_heading()); - status = ExitStatus::SUCCESS; } else { output::error(lint_message_kind.issue_heading()); } diff --git a/packages/cli/snap-tests/check-lint-warn-deny-warnings/package.json b/packages/cli/snap-tests/check-lint-warn-deny-warnings/package.json new file mode 100644 index 0000000000..643b60208b --- /dev/null +++ b/packages/cli/snap-tests/check-lint-warn-deny-warnings/package.json @@ -0,0 +1,5 @@ +{ + "name": "check-lint-warn-deny-warnings", + "version": "0.0.0", + "private": true +} diff --git a/packages/cli/snap-tests/check-lint-warn-deny-warnings/snap.txt b/packages/cli/snap-tests/check-lint-warn-deny-warnings/snap.txt new file mode 100644 index 0000000000..655232799e --- /dev/null +++ b/packages/cli/snap-tests/check-lint-warn-deny-warnings/snap.txt @@ -0,0 +1,13 @@ +[1]> vp check +pass: All 4 files are correctly formatted (ms, threads) +warn: Lint warnings found +⚠ eslint(no-console): Unexpected console statement. + ╭─[src/index.js:2:3] + 1 │ function hello() { + 2 │ console.log("hello"); + · ─────────── + 3 │ } + ╰──── + help: Delete this console statement. + +Found 0 errors and 1 warning in 2 files (ms, threads) diff --git a/packages/cli/snap-tests/check-lint-warn-deny-warnings/src/index.js b/packages/cli/snap-tests/check-lint-warn-deny-warnings/src/index.js new file mode 100644 index 0000000000..9373ddd734 --- /dev/null +++ b/packages/cli/snap-tests/check-lint-warn-deny-warnings/src/index.js @@ -0,0 +1,5 @@ +function hello() { + console.log("hello"); +} + +export { hello }; diff --git a/packages/cli/snap-tests/check-lint-warn-deny-warnings/steps.json b/packages/cli/snap-tests/check-lint-warn-deny-warnings/steps.json new file mode 100644 index 0000000000..d9c26d5a29 --- /dev/null +++ b/packages/cli/snap-tests/check-lint-warn-deny-warnings/steps.json @@ -0,0 +1,6 @@ +{ + "env": { + "VITE_DISABLE_AUTO_INSTALL": "1" + }, + "commands": ["vp check"] +} diff --git a/packages/cli/snap-tests/check-lint-warn-deny-warnings/vite.config.ts b/packages/cli/snap-tests/check-lint-warn-deny-warnings/vite.config.ts new file mode 100644 index 0000000000..4957dbe218 --- /dev/null +++ b/packages/cli/snap-tests/check-lint-warn-deny-warnings/vite.config.ts @@ -0,0 +1,10 @@ +export default { + lint: { + options: { + denyWarnings: true, + }, + rules: { + "no-console": "warn", + }, + }, +};